Bug 186875

Summary: [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, conrad_shultz, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
andersca: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews202 for win-future none

Darin Adler
Reported 2018-06-20 20:16:37 PDT
[Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
Attachments
Patch (21.10 KB, patch)
2018-06-20 20:28 PDT, Darin Adler 		andersca: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews202 for win-future (12.50 MB, application/zip)
2018-06-21 02:55 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2018-06-20 20:28:24 PDT
Created attachment 343208 [details] Patch
Conrad Shultz
Comment 2 2018-06-20 22:40:09 PDT
Comment on attachment 343208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343208&action=review Looks good to me, though I can't r+. > Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:3962 > + if (![wrapper writeToURL:[NSURL fileURLWithPath:path isDirectory:NO] options:NSFileWrapperWritingWithNameUpdating originalContentsURL:nil error:nullptr]) A few lines earlier, we use `m_promisedURL` when initializing the file wrapper, but use the plain `+URLWithString:`. It seems like `m_promisedURL` must also be a file URL, so should that be changed? Since this is apparently used only for saving images, this change seems correct, but I'm a little wary since file wrappers can refer to directories.
EWS Watchlist
Comment 3 2018-06-21 02:55:23 PDT
Comment on attachment 343208 [details] Patch Attachment 343208 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8275207 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
EWS Watchlist
Comment 4 2018-06-21 02:55:34 PDT
Created attachment 343228 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Darin Adler
Comment 5 2018-06-22 08:04:02 PDT
Committed r233079: <https://trac.webkit.org/changeset/233079>
Radar WebKit Bug Importer
Comment 6 2018-06-22 08:07:26 PDT
<rdar://problem/41368124>
Note You need to log in before you can comment on or make changes to this bug.