Bug 186865 – Fix leaks in WebCore found by clang static analyzer in deep mode

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

Fix leaks in WebCore found by clang static analyzer in deep mode.

[David Kilzer (:ddkilzer)]

Created attachment 343186 [details]
Patch v1

[David Kilzer (:ddkilzer)]

Comment on attachment 343186 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=343186&action=review

> Source/WebCore/platform/mac/WebCoreNSURLExtras.mm:783
> +    if (![hostNameRanges count]) {
> +        [hostNameRanges release];
>          return nil;
> +    }

I considered changing the `hostNameRanges` declaration from this:

    NSMutableArray *hostNameRanges = nil;

To this:

    RetainPtr<NSMutableArray> hostNameRanges;

And then change functions to take a RetainPtr<NSMutableArray>& instead of NSMutableArray **.

I'm happy to do that instead, although I didn't want to overthink the change.

[Joseph Pecoraro]

Comment on attachment 343186 [details]
Patch v1

r=me

[EWS Watchlist]

Comment on attachment 343186 [details]
Patch v1

Attachment 343186 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8270290

New failing tests:
accessibility/mac/selection-notification-focus-change.html

[EWS Watchlist]

Created attachment 343190 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[David Kilzer (:ddkilzer)]

(In reply to Build Bot from comment #4)
> Comment on attachment 343186 [details]
> Patch v1
> 
> Attachment 343186 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: https://webkit-queues.webkit.org/results/8270290
> 
> New failing tests:
> accessibility/mac/selection-notification-focus-change.html

Looks flakey to me without this change:
<https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=accessibility%2Fmac%2Fselection-notification-focus-change.html>

[WebKit Commit Bot]

Comment on attachment 343186 [details]
Patch v1

Clearing flags on attachment: 343186

Committed r233029: <https://trac.webkit.org/changeset/233029>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/41315464>