Summary: | check-webkit-style should warn about exported inline functions | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Rollin <krollin> | ||||||||||
Component: | Tools / Tests | Assignee: | Keith Rollin <krollin> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ap, bfulgham, cgarcia, commit-queue, ddkilzer, ews-watchlist, glenn, lforschler, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Keith Rollin
2018-06-20 14:09:43 PDT
Created attachment 343179 [details]
Patch
OK, for the record, I ran test-webkitpy locally and it passed. I don't know why it's failing here. Harrumph. Created attachment 343180 [details]
Patch
Comment on attachment 343180 [details] Patch Attachment 343180 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8275529 New failing tests: http/tests/security/contentSecurityPolicy/video-with-https-url-allowed-by-csp-media-src-star.html Created attachment 343233 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 343180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343180&action=review Looks good. Hopefully we can activate LTO soon! Removing cq- since this checker change can't affect windows tests. > Tools/ChangeLog:25 > + Unfortunately, these errors are not emitted when LTO is not enabled, I had to read this sentence a couple of times (double negatives). I propose: "Unfortunately, these errors are only emitted when LTO is enabled," (In reply to Brent Fulgham from comment #7) > > Tools/ChangeLog:25 > > + Unfortunately, these errors are not emitted when LTO is not enabled, > > I had to read this sentence a couple of times (double negatives). I propose: > > "Unfortunately, these errors are only emitted when LTO is enabled," You don't have a lack of problems with double-negative sentences? Fine, I'll not keep it the same. Created attachment 343251 [details]
Patch
Comment on attachment 343251 [details] Patch Clearing flags on attachment: 343251 Committed r233054: <https://trac.webkit.org/changeset/233054> All reviewed patches have been landed. Closing bug. |