Summary: | [WPE][GTK] ASSERTION FAILED: url == m_string in UserAgentQuirks test | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bugs-noreply, calvaris, commit-queue, ews-watchlist, fred.wang, mcatanzaro, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Rob Buis
2018-06-20 01:27:53 PDT
Created attachment 343142 [details]
Patch
Comment on attachment 343142 [details] Patch OK, I think the slash is not important in the test for user agent quirks and other URLs use it, so let's do it. The core issue seems to be bug 167093 though, it would be nice to fix it at some point... (In reply to Frédéric Wang (:fredw) from comment #2) > Comment on attachment 343142 [details] > Patch > > OK, I think the slash is not important in the test for user agent quirks and > other URLs use it, so let's do it. The core issue seems to be bug 167093 > though, it would be nice to fix it at some point... Actually per bug 167093 comment 3, it is wrong to pass a non-canonicalized URL so we must take this patch. Comment on attachment 343142 [details] Patch Clearing flags on attachment: 343142 Committed r233008: <https://trac.webkit.org/changeset/233008> All reviewed patches have been landed. Closing bug. Thanks for this fix. Please remember to CC bugs-noreply@webkitgtk.org so that we all see the bug! It's done automatically if you select the 'WebKit Gtk' or 'WebKit WPE' Bugzilla components, but when you pick other components it has to be done manually. Will do! May be even better if it was done automatically given the [GTK] prefix. Bugzilla is not smart enough for that, I'm afraid.... Reopening to attach new patch. Created attachment 344059 [details]
Patch
Comment on attachment 344059 [details]
Patch
Sigh, we really need to improve our gardening so that we can get a handle on these issues. No doubt the test started failing immediately after I introduced this bug, but probably nobody has checked the API tests on the debug bot ever since.
Comment on attachment 344059 [details] Patch Attachment 344059 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8406605 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html Created attachment 344063 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 344059 [details] Patch Clearing flags on attachment: 344059 Committed r233416: <https://trac.webkit.org/changeset/233416> All reviewed patches have been landed. Closing bug. |