Bug 186819

Summary:

Corner of two scroll bars is white with dark mode enabled

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

WebKit2

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, ews-watchlist, megan_gardner, rniwa, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Timothy Hatcher

Reported 2018-06-19 14:02:00 PDT

The corner is always white. <rdar://problem/40434350>

Attachments
Patch (58.73 KB, patch) 2018-06-19 14:16 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (60.10 KB, patch) 2018-06-19 14:52 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (60.15 KB, patch) 2018-06-19 14:54 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (60.73 KB, patch) 2018-06-19 15:28 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (63.00 KB, patch) 2018-06-20 11:57 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.77 MB, application/zip) 2018-06-20 13:14 PDT, EWS Watchlist	no flags	Details
Patch (64.50 KB, patch) 2018-06-20 15:07 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (66.42 KB, patch) 2018-06-22 10:25 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (37.23 KB, patch) 2018-06-22 16:04 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (36.97 KB, patch) 2018-06-22 16:24 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (37.03 KB, patch) 2018-06-22 16:42 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (36.85 KB, patch) 2018-06-22 17:49 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2018-06-19 14:16:33 PDT Comment hidden (obsolete)

Created attachment 343098 [details] Patch

Timothy Hatcher

Comment 2 2018-06-19 14:52:30 PDT Comment hidden (obsolete)

Created attachment 343104 [details] Patch

Timothy Hatcher

Comment 3 2018-06-19 14:54:37 PDT Comment hidden (obsolete)

Created attachment 343105 [details] Patch

Timothy Hatcher

Comment 4 2018-06-19 15:28:30 PDT Comment hidden (obsolete)

Created attachment 343112 [details] Patch

Timothy Hatcher

Comment 5 2018-06-20 11:57:01 PDT Comment hidden (obsolete)

Created attachment 343172 [details] Patch

EWS Watchlist

Comment 6 2018-06-20 13:14:05 PDT Comment hidden (obsolete)

Comment on attachment 343172 [details] Patch Attachment 343172 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8268245 New failing tests: http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm

EWS Watchlist

Comment 7 2018-06-20 13:14:07 PDT Comment hidden (obsolete)

Created attachment 343177 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Timothy Hatcher

Comment 8 2018-06-20 15:07:25 PDT Comment hidden (obsolete)

Created attachment 343184 [details] Patch

Simon Fraser (smfr)

Comment 9 2018-06-21 15:26:09 PDT Comment hidden (obsolete)

Comment on attachment 343184 [details] Patch Is there a way to do this that doesn't plumb those two bools through, which pollutes a lot of function signatures?

Timothy Hatcher

Comment 10 2018-06-22 10:25:34 PDT Comment hidden (obsolete)

Created attachment 343336 [details] Patch

Timothy Hatcher

Comment 11 2018-06-22 10:28:45 PDT Comment hidden (obsolete)

(In reply to Simon Fraser (smfr) from comment #9) > Comment on attachment 343184 [details] > Patch > > Is there a way to do this that doesn't plumb those two bools through, which > pollutes a lot of function signatures? I agree. It is a mess as-is. One way would be to add LocalDefaultSystemAppearance at the top levels anywhere we draw. I'll see if that would be an option.

Timothy Hatcher

Comment 12 2018-06-22 16:04:11 PDT Comment hidden (obsolete)

Created attachment 343387 [details] Patch

Tim Horton

Comment 13 2018-06-22 16:10:47 PDT Comment hidden (obsolete)

Comment on attachment 343387 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343387&action=review > Source/WebKit/UIProcess/mac/WKPrintingView.mm:571 > +#if PLATFORM(MAC) This whole file is PLATFORM(MAC)

Timothy Hatcher

Comment 14 2018-06-22 16:24:50 PDT Comment hidden (obsolete)

Created attachment 343393 [details] Patch

Timothy Hatcher

Comment 15 2018-06-22 16:42:40 PDT Comment hidden (obsolete)

Created attachment 343394 [details] Patch

Tim Horton

Comment 16 2018-06-22 17:27:55 PDT Comment hidden (obsolete)

Comment on attachment 343394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343394&action=review The PLATFORM(MAC)s everywhere are so sad. > Source/WebCore/PAL/pal/spi/mac/NSAppearanceSPI.h:2 > + * Copyright (C) 2015 Apple Inc. All rights reserved. 2018 > Source/WebCore/platform/mac/ScrollbarThemeMac.mm:574 > + auto cornerDrawingOptions = adoptCF(CFDictionaryCreateMutable(kCFAllocatorDefault, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks)); > + > + CFDictionarySetValue(cornerDrawingOptions.get(), kCUIWidgetKey, kCUIWidgetScrollBarTrackCorner); > + CFDictionarySetValue(cornerDrawingOptions.get(), kCUIIsFlippedKey, kCFBooleanTrue); Why not just a ObjC dictionary literal?

Timothy Hatcher

Comment 17 2018-06-22 17:49:06 PDT

Created attachment 343404 [details] Patch

WebKit Commit Bot

Comment 18 2018-06-22 18:21:20 PDT

Comment on attachment 343404 [details] Patch Clearing flags on attachment: 343404 Committed r233116: <https://trac.webkit.org/changeset/233116>

WebKit Commit Bot

Comment 19 2018-06-22 18:21:21 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.