Bug 186800 – [WTF] Coverity scan issues

• Component: Web Template Framework
• Status: RESOLVED FIXED

[Tomas Popela]

Error: SWAPPED_ARGUMENTS (CWE-683):
webkitgtk-2.20.3/Source/WTF/wtf/CheckedArithmetic.h:420: swapped_arguments: The positions of arguments in the call to "multiply" do not match the ordering of the parameters:
* "rhs" is passed to "lhs"
* "lhs" is passed to "rhs"
webkitgtk-2.20.3/Source/WTF/wtf/CheckedArithmetic.h:391:5: param_names: The parameters are called: "lhs", "rhs" and "result".
#  418|       static inline bool multiply(int64_t lhs, int64_t rhs, ResultType& result)
#  419|       {
#  420|->         return ArithmeticOperations<int, unsigned, ResultType>::multiply(rhs, lhs, result);
#  421|       }
#  422|   

Error: UNINIT_CTOR (CWE-456):
webkitgtk-2.20.3/Source/WTF/wtf/ThreadSpecific.h:125: member_decl: Class member declaration for "m_key".
webkitgtk-2.20.3/Source/WTF/wtf/ThreadSpecific.h:167: uninit_member: Non-static class member "m_key" is not initialized in this constructor nor in any functions that it calls.
#  165|       if (error)
#  166|           CRASH();
#  167|-> }
#  168|   
#  169|   template<typename T, CanBeGCThread canBeGCThread>

Error: UNINIT_CTOR (CWE-456):
webkitgtk-2.20.3/Source/WTF/wtf/dtoa.cpp:363: member_decl: Class member declaration for "next".
webkitgtk-2.20.3/Source/WTF/wtf/dtoa.cpp:361: uninit_member: Non-static class member "next" is not initialized in this constructor nor in any functions that it calls.
#  359|       WTF_MAKE_NONCOPYABLE(P5Node); WTF_MAKE_FAST_ALLOCATED;
#  360|   public:
#  361|->     P5Node() { }
#  362|       BigInt val;
#  363|       P5Node* next;

[Tomas Popela]

Created attachment 343031 [details]
Patch

[EWS Watchlist]

Comment on attachment 343031 [details]
Patch

Attachment 343031 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/8246345

New failing tests:
accessibility/mac/selection-notification-focus-change.html

[EWS Watchlist]

Created attachment 343049 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Alexey Proskuryakov]

Comment on attachment 343031 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343031&action=review

> Source/WTF/ChangeLog:3
> +        [WTF] Coverity scan issues

Does this fix any bugs?

[EWS Watchlist]

Comment on attachment 343031 [details]
Patch

Attachment 343031 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8251036

New failing tests:
http/tests/preload/onload_event.html

[EWS Watchlist]

Created attachment 343091 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Tomas Popela]

(In reply to Alexey Proskuryakov from comment #4)
> Does this fix any bugs?

Nothing that I'm aware of. But potentially the uninitialized variables could cause something.

[Brent Fulgham]

Comment on attachment 343031 [details]
Patch

This seems very reasonable. r=me. I don't see how the Windows test could be related to these safe changes.

[Tomas Popela]

Comment on attachment 343031 [details]
Patch

Clearing flags on attachment: 343031

Committed r234251: <https://trac.webkit.org/changeset/234251>

[Tomas Popela]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/42616736>