Bug 186778
| Summary: | [GTK] Tests sometimes crash when secret service is not running | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bugs-noreply, calvaris, mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=182352 | ||
Michael Catanzaro
Layout test http/tests/misc/cached-scripts.html sometimes crashes on the GTK EWS, but never on the release bot. The difference is that the secret service is not running on the EWS:
STDERR: ** Message: Remote error from secret service: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.secrets was not provided by any .service files
Although the EWS should be fixed, we also need to fix WebKit to not crash in this case.
Thread 1 (Thread 0x7f410c0dd3c0 (LWP 65802)):
#0 0x00007f411a838c2b in WebKit::PingLoad::didFinish(WebCore::ResourceError const&, WebCore::ResourceResponse const&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#1 0x00007f411a83c9d3 in WebKit::PingLoad::didReceiveChallenge(WebCore::AuthenticationChallenge const&, WTF::CompletionHandler<void (WebKit::AuthenticationChallengeDisposition, WebCore::Credential const&)>&&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#2 0x00007f411ac04956 in WebKit::NetworkDataTaskSoup::continueAuthenticate(WebCore::AuthenticationChallenge&&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#3 0x00007f411bc2d205 in WebCore::NetworkStorageSession::getCredentialFromPersistentStorage(WebCore::ProtectionSpace const&, _GCancellable*, WTF::Function<void (WebCore::Credential&&)>&&)::{lambda(_GObject*, _GAsyncResult*, void*)#1}::_FUN(_GObject*, _GAsyncResult*, void*) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#4 0x00007f411406ab37 in g_simple_async_result_complete () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gsimpleasyncresult.c:801
#5 0x00007f4113e4a1be in on_search_paths (source=<optimized out>, result=0x556ba67afa60, user_data=<optimized out>) at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/libsecret-0.18.5/libsecret/secret-methods.c:231
#6 0x00007f411406ab37 in g_simple_async_result_complete () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gsimpleasyncresult.c:801
#7 0x00007f4113e512e7 in on_search_items_complete (source=0x7f40a8004ce0, result=0x7f40a8004900, user_data=<optimized out>) at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/libsecret-0.18.5/libsecret/secret-paths.c:316
#8 0x00007f411407baf3 in g_task_return_now () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gtask.c:1145
#9 0x00007f411407c596 in g_task_return () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gtask.c:1203
#10 0x00007f41140b8d25 in reply_cb () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gdbusproxy.c:2579
#11 0x00007f411407baf3 in g_task_return_now () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gtask.c:1145
#12 0x00007f411407c596 in g_task_return () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gtask.c:1203
#13 0x00007f41140adc02 in g_dbus_connection_call_done () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gdbusconnection.c:5720
#14 0x00007f411407baf3 in g_task_return_now () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gtask.c:1145
#15 0x00007f411407bb29 in complete_in_idle_cb () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gtask.c:1159
#16 0x00007f4113ecc81a in g_main_dispatch () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3148
#17 g_main_context_dispatch () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3813
#18 0x00007f4113eccba8 in g_main_context_iterate () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3886
#19 0x00007f4113eccec2 in g_main_loop_run () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:4082
#20 0x00007f41188ca820 in WTF::RunLoop::run() () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#21 0x00007f411ac00182 in NetworkProcessMainUnix () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#22 0x00007f4111f0c2e1 in __libc_start_main (main=0x556ba51deca0 <main>, argc=3, argv=0x7ffcab66d648, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffcab66d638) at ../csu/libc-start.c:291
#23 0x0000556ba51ded2a in _start ()
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
BTW, it is a flaky crash, not something that always happens.
Would be nice to have a better trace from a debug build.