Summary: | Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dimcho Balev <dbalev> | ||||||||
Component: | Plug-ins | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, ap, marc.ordinasillopis | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Dimcho Balev
2008-04-22 00:33:06 PDT
Created attachment 20745 [details]
First crude patch (mac only)
This is my first patch. I realize that it is Mac only and will break the windows build. I am also no sure if it modifies the right classes. I just wanted to have something concrete that will help having more focused discussions.
The approach looks good and should work well on both Windows and Mac. The patch does violate the Web Kit style guidelines described on http://webkit.org/coding/coding-style.html but other than that I think it is a great idea. Created attachment 21423 [details]
Updated the patch with new constant name and value
Created attachment 22298 [details]
Fixed a bug about missing http status line. Added Windows/Linux code
- This patch includes the corresponding code for Windows/Linux that was absent from the previous patches (they updated the Mac version only).
- I also added a fix for windows specific bug about missing http status line from the http headers that webkit passes to the plugins.
- Some minor format changes
Comment on attachment 22298 [details]
Fixed a bug about missing http status line. Added Windows/Linux code
Looks great. I've committed it with a few tweaks. I haven't committed the Windows parts but that's next.
(I didn't commit the header changes. Could you please file a new bug for that?)
Logged a separate bug for the missing status line on windows: Bug 20202 Committed revision 35417. |