Bug 186748 – QueueStatusServer: "'NoneType' object has no attribute 'message'" in ReleasePatch.get() when attachment is skipped by queue

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Daniel Bates]

QueueStatusServer: "'NoneType' object has no attribute 'message'" in ReleasePatch.get() when attachment is skipped by queue.

The backtrace has the form:

'NoneType' object has no attribute 'message'
Traceback (most recent call last):
File "/.../webapp2.py", line 1511, in __call__
rv = self.handle_exception(request, response, e)
File "/.../webapp2.py", line 1505, in __call__
rv = self.router.dispatch(request, response)
File "/.../webapp2.py", line 1253, in default_dispatcher
return route.handler_adapter(request, response)
File "/.../webapp2.py", line 1077, in __call__
return handler.dispatch()
File "/.../webapp2.py", line 547, in dispatch
return self.handle_exception(e, self.app.debug)
File "/.../webapp2.py", line 545, in dispatch
return method(*args, **kwargs)
File "/.../handlers/releasepatch.py", line 59, in post
RecordPatchEvent.stopped(attachment_id, queue_name, last_status.message)
AttributeError: 'NoneType' object has no attribute 'message'

[Daniel Bates]

Created attachment 342902 [details]
Patch

[EWS Watchlist]

Attachment 342902 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:10:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: security bug, security bug  [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

Created attachment 342905 [details]
Patch and unit tests

[Daniel Bates]

Comment on attachment 342905 [details]
Patch and unit tests

Clearing flags on attachment: 342905

Committed r232973: <https://trac.webkit.org/changeset/232973>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/41259861>

[Daniel Bates]

*** Bug 171463 has been marked as a duplicate of this bug. ***