Summary: | SquirrelFish: continue inside switch fails | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||||
Component: | JavaScriptCore | Assignee: | Cameron Zwarich (cpst) <zwarich> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ggaren, mjs, oliver, zwarich | ||||||
Priority: | P2 | Keywords: | EasyFix | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Oliver Hunt
2008-04-21 15:46:13 PDT
Created attachment 20741 [details]
Proposed patch
Here is a fix.
Comment on attachment 20741 [details]
Proposed patch
I'd prefer:
+ if (forContinue) {
+ for (int i = m_jumpContextStack.size() - 1; i >= 0; i--) {
+ JumpContext* scope = &m_jumpContextStack[i];
+ if (scope->continueTarget)
+ return scope;
+ }
+ return 0;
+ }
But other than that, r=me
Created attachment 20742 [details]
Revised proposed patch
Modified as per Oliver's suggestion.
|