Bug 186706

Summary: ContentSecurityPolicySourceList wastes 51KB of Vector capacity on cnn.com
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Page LoadingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, dbates, ews-watchlist, mkwst, simon.fraser, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2018-06-15 15:08:36 PDT
Tooling from bug 186698: Wasted capacity: 51264 bytes (used 13248 of 64512 bytes, utilization: 20.54%) - 132 allocations 1 0x10810c735 WTF::VectorBuffer<WebCore::ContentSecurityPolicySource, 0ul>::VectorBuffer() 2 0x10810c715 WTF::Vector<WebCore::ContentSecurityPolicySource, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 3 0x108109d05 WTF::Vector<WebCore::ContentSecurityPolicySource, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 4 0x108109c72 WebCore::ContentSecurityPolicySourceList::ContentSecurityPolicySourceList(WebCore::ContentSecurityPolicy const&, WTF::String const&) 5 0x108109d55 WebCore::ContentSecurityPolicySourceList::ContentSecurityPolicySourceList(WebCore::ContentSecurityPolicy const&, WTF::String const&) 6 0x10810bec7 WebCore::ContentSecurityPolicySourceListDirective::ContentSecurityPolicySourceListDirective(WebCore::ContentSecurityPolicyDirectiveList const&, WTF::String const&, WTF::String const&) 7 0x10810bf1d WebCore::ContentSecurityPolicySourceListDirective::ContentSecurityPolicySourceListDirective(WebCore::ContentSecurityPolicyDirectiveList const&, WTF::String const&, WTF::String const&) 8 0x1080f0e3f void WebCore::ContentSecurityPolicyDirectiveList::setCSPDirective<WebCore::ContentSecurityPolicySourceListDirective>(WTF::String const&, WTF::String const&, std::__1::unique_ptr<WebCore::ContentSecurityPolicySourceListDirective, std::__1::default_delete<WebCore::ContentSecurityPolicySourceListDirective> >&)
Attachments
Patch (4.19 KB, patch)
2018-06-20 11:29 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-06-15 15:09:06 PDT
<rdar://problem/41173711>
Chris Dumez
Comment 2 2018-06-15 15:14:43 PDT
Adding Daniel to cc since this is CSP.
Simon Fraser (smfr)
Comment 3 2018-06-20 11:29:24 PDT
Created attachment 343168 [details] Patch
WebKit Commit Bot
Comment 4 2018-06-20 12:39:07 PDT
Comment on attachment 343168 [details] Patch Clearing flags on attachment: 343168 Committed r233019: <https://trac.webkit.org/changeset/233019>
WebKit Commit Bot
Comment 5 2018-06-20 12:39:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.