Summary: | CodeBlock's SegmentedVector wastes almost 400KB of Vector capacity on theverge.com | ||
---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED CONFIGURATION CHANGED | ||
Severity: | Normal | CC: | saam, simon.fraser, webkit-bug-importer, ysuzuki |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Simon Fraser (smfr)
2018-06-15 15:02:48 PDT
On nytimes.com: Wasted capacity: 125336 bytes (used 16456 of 141792 bytes, utilization: 11.61%) - 1434 allocations 1 0x115829225 WTF::VectorBuffer<WTF::SegmentedVector<JSC::ArrayProfile, 4ul>::Segment*, 0ul>::VectorBuffer() 2 0x115829205 WTF::Vector<WTF::SegmentedVector<JSC::ArrayProfile, 4ul>::Segment*, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 3 0x1158291e5 WTF::Vector<WTF::SegmentedVector<JSC::ArrayProfile, 4ul>::Segment*, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 4 0x1158291c0 WTF::SegmentedVector<JSC::ArrayProfile, 4ul>::SegmentedVector() 5 0x11580fc45 WTF::SegmentedVector<JSC::ArrayProfile, 4ul>::SegmentedVector() 6 0x1158113aa JSC::CodeBlock::CodeBlock(JSC::VM*, JSC::Structure*, JSC::ScriptExecutable*, JSC::UnlinkedCodeBlock*, JSC::JSScope*, WTF::RefPtr<JSC::SourceProvider, WTF::DumbPtrTraits<JSC::SourceProvider> >&&, unsigned int, unsigned int) 7 0x1167404fb JSC::FunctionCodeBlock::FunctionCodeBlock(JSC::VM*, JSC::Structure*, JSC::FunctionExecutable*, JSC::UnlinkedFunctionCodeBlock*, JSC::JSScope*, WTF::RefPtr<JSC::SourceProvider, WTF::DumbPtrTraits<JSC::SourceProvider> >&&, unsigned int, unsigned int) 8 0x116740292 JSC::FunctionCodeBlock::FunctionCodeBlock(JSC::VM*, JSC::Structure*, JSC::FunctionExecutable*, JSC::UnlinkedFunctionCodeBlock*, JSC::JSScope*, WTF::RefPtr<JSC::SourceProvider, WTF::DumbPtrTraits<JSC::SourceProvider> >&&, unsigned int, unsigned int) cnn.com: Wasted capacity: 121520 bytes (used 20496 of 142016 bytes, utilization: 14.43%) - 1317 allocations 1 0x115829225 WTF::VectorBuffer<WTF::SegmentedVector<JSC::ArrayProfile, 4ul>::Segment*, 0ul>::VectorBuffer() 2 0x115829205 WTF::Vector<WTF::SegmentedVector<JSC::ArrayProfile, 4ul>::Segment*, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 3 0x1158291e5 WTF::Vector<WTF::SegmentedVector<JSC::ArrayProfile, 4ul>::Segment*, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 4 0x1158291c0 WTF::SegmentedVector<JSC::ArrayProfile, 4ul>::SegmentedVector() 5 0x11580fc45 WTF::SegmentedVector<JSC::ArrayProfile, 4ul>::SegmentedVector() 6 0x1158113aa JSC::CodeBlock::CodeBlock(JSC::VM*, JSC::Structure*, JSC::ScriptExecutable*, JSC::UnlinkedCodeBlock*, JSC::JSScope*, WTF::RefPtr<JSC::SourceProvider, WTF::DumbPtrTraits<JSC::SourceProvider> >&&, unsigned int, unsigned int) 7 0x1167404fb JSC::FunctionCodeBlock::FunctionCodeBlock(JSC::VM*, JSC::Structure*, JSC::FunctionExecutable*, JSC::UnlinkedFunctionCodeBlock*, JSC::JSScope*, WTF::RefPtr<JSC::SourceProvider, WTF::DumbPtrTraits<JSC::SourceProvider> >&&, unsigned int, unsigned int) 8 0x116740292 JSC::FunctionCodeBlock::FunctionCodeBlock(JSC::VM*, JSC::Structure*, JSC::FunctionExecutable*, JSC::UnlinkedFunctionCodeBlock*, JSC::JSScope*, WTF::RefPtr<JSC::SourceProvider, WTF::DumbPtrTraits<JSC::SourceProvider> >&&, unsigned int, unsigned int) Hmm, I thought we shrunk it? Oh, this is for ArrayProfile. Got it. Just saw almost 400KB on theverge.com: Wasted capacity: 394016 bytes (used 58952 of 452968 bytes, utilization: 13.01%). 4460 allocations. Non-empty size range 8 to 888, non-empty capacity range 128-1088 1 0x1156dc9b5 WTF::VectorBuffer<WTF::SegmentedVector<JSC::ArrayProfile, 4ul>::Segment*, 0ul>::VectorBuffer() 2 0x1156dc995 WTF::Vector<WTF::SegmentedVector<JSC::ArrayProfile, 4ul>::Segment*, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 3 0x1156dc975 WTF::Vector<WTF::SegmentedVector<JSC::ArrayProfile, 4ul>::Segment*, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 4 0x1156dc950 WTF::SegmentedVector<JSC::ArrayProfile, 4ul>::SegmentedVector() 5 0x1156c34c5 WTF::SegmentedVector<JSC::ArrayProfile, 4ul>::SegmentedVector() 6 0x1156c4c0d JSC::CodeBlock::CodeBlock(JSC::VM*, JSC::Structure*, JSC::ScriptExecutable*, JSC::UnlinkedCodeBlock*, JSC::JSScope*, WTF::RefPtr<JSC::SourceProvider, WTF::DumbPtrTraits<JSC::SourceProvider> >&&, unsigned int, unsigned int) It's now moved to bytecode Metadata. ArrayProfile is now handled in metadata. |