Bug 186701

Summary: AnimationList wastes 60KB of vector capacity
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: AnimationsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, ews-watchlist, graouts, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews106 for mac-sierra-wk2 none

Description Simon Fraser (smfr) 2018-06-15 15:01:24 PDT 
On theverge.com, tooling from bug 186698:

Wasted capacity: 59032 bytes (used 7872 of 66904 bytes, utilization: 11.77%) - 335 allocations
1   0x1081bacb5 WTF::VectorBuffer<WTF::Ref<WebCore::Animation, WTF::DumbPtrTraits<WebCore::Animation> >, 0ul>::VectorBuffer()
2   0x1081bac95 WTF::Vector<WTF::Ref<WebCore::Animation, WTF::DumbPtrTraits<WebCore::Animation> >, 0ul, WTF::CrashOnOverflow, 16ul>::Vector()
3   0x1081b84b5 WTF::Vector<WTF::Ref<WebCore::Animation, WTF::DumbPtrTraits<WebCore::Animation> >, 0ul, WTF::CrashOnOverflow, 16ul>::Vector()
4   0x1089d5615 WebCore::AnimationList::AnimationList()
5   0x1089d55f5 WebCore::AnimationList::AnimationList()
6   0x1089c30e4 WebCore::RenderStyle::ensureTransitions()
7   0x106aaae64 WebCore::StyleBuilderFunctions::applyValueTransitionDelay(WebCore::StyleResolver&, WebCore::CSSValue&)
8   0x106a8f4cf WebCore::StyleBuilder::applyProperty(WebCore::CSSPropertyID, WebCore::StyleResolver&, WebCore::CSSValue&, bool, bool)
Comment 1 Radar WebKit Bug Importer 2018-06-15 15:01:56 PDT 
<rdar://problem/41173415>
Comment 2 Simon Fraser (smfr) 2018-06-20 11:14:50 PDT 
Created attachment 343166 [details]
Patch
Comment 3 EWS Watchlist 2018-06-20 12:54:38 PDT 
Comment on attachment 343166 [details]
Patch

Attachment 343166 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8268115

New failing tests:
accessibility/mac/selection-notification-focus-change.html
Comment 4 EWS Watchlist 2018-06-20 12:54:39 PDT 
Created attachment 343176 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 WebKit Commit Bot 2018-06-20 13:23:23 PDT 
Comment on attachment 343166 [details]
Patch

Clearing flags on attachment: 343166

Committed r233020: <https://trac.webkit.org/changeset/233020>
Comment 6 WebKit Commit Bot 2018-06-20 13:23:24 PDT 
All reviewed patches have been landed.  Closing bug.