Bug 186647

Summary: sun spider compile time benchmark fails in run-jsc-benchmarks with JSC_validateOptions=1
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2018-06-14 22:06:30 PDT
Let's use `unset JSC_useBlah` to clear the environment variables instead of `export JSC_useBlah=`
Attachments
patch (1.23 KB, patch)
2018-06-14 22:13 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2018-06-14 22:13:28 PDT
Created attachment 342790 [details] patch
Yusuke Suzuki
Comment 2 2018-06-14 22:29:46 PDT
Comment on attachment 342790 [details] patch r=me
WebKit Commit Bot
Comment 3 2018-06-14 23:28:24 PDT
Comment on attachment 342790 [details] patch Clearing flags on attachment: 342790 Committed r232867: <https://trac.webkit.org/changeset/232867>
WebKit Commit Bot
Comment 4 2018-06-14 23:28:26 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-06-14 23:29:20 PDT
<rdar://problem/41151943>
Note You need to log in before you can comment on or make changes to this bug.