Bug 186614 – Make it possible to add a border around loading or failed-to-load images

• Component: New Bugs
• Status: RESOLVED FIXED

[Tim Horton]

Make it possible to add a border around loading or failed-to-load images

[Tim Horton]

Created attachment 342717 [details]
Patch

[EWS Watchlist]

Comment on attachment 342717 [details]
Patch

Attachment 342717 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/8171818

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 342718 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

[alan]

Comment on attachment 342717 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342717&action=review

> Source/WebCore/rendering/RenderImage.cpp:381
> +void RenderImage::paintIncompleteImageOutline(PaintInfo& paintInfo, const LayoutPoint& paintOffset, const LayoutUnit& borderWidth)

void RenderImage::paintIncompleteImageOutline(PaintInfo& paintInfo, LayoutPoint paintOffset, LayoutUnit borderWidth)

> Source/WebCore/rendering/RenderImage.cpp:390
> +    LayoutUnit leftBorder = borderLeft();
> +    LayoutUnit topBorder = borderTop();
> +    LayoutUnit leftPad = paddingLeft();
> +    LayoutUnit topPad = paddingTop();

auto
and please don't abbrev.

> Source/WebCore/rendering/RenderImage.cpp:480
> +    LayoutUnit incompleteImageBorderWidth = LayoutUnit(2 / deviceScaleFactor);

This makes the image borders thicker. is it intentional?

> Source/WebCore/rendering/RenderImage.h:110
> +    void paintIncompleteImageOutline(PaintInfo&, const LayoutPoint&, const LayoutUnit&);

shouldn't this paint function be const?

[EWS Watchlist]

Comment on attachment 342717 [details]
Patch

Attachment 342717 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/8171988

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 342719 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Tim Horton]

(In reply to zalan from comment #4)
> Comment on attachment 342717 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342717&action=review
> 
> > Source/WebCore/rendering/RenderImage.cpp:381
> > +void RenderImage::paintIncompleteImageOutline(PaintInfo& paintInfo, const LayoutPoint& paintOffset, const LayoutUnit& borderWidth)
> 
> void RenderImage::paintIncompleteImageOutline(PaintInfo& paintInfo,
> LayoutPoint paintOffset, LayoutUnit borderWidth)
> 
> > Source/WebCore/rendering/RenderImage.cpp:390
> > +    LayoutUnit leftBorder = borderLeft();
> > +    LayoutUnit topBorder = borderTop();
> > +    LayoutUnit leftPad = paddingLeft();
> > +    LayoutUnit topPad = paddingTop();
> 
> auto
> and please don't abbrev.

Just moved, but fine :)

> > Source/WebCore/rendering/RenderImage.cpp:480
> > +    LayoutUnit incompleteImageBorderWidth = LayoutUnit(2 / deviceScaleFactor);
> 
> This makes the image borders thicker. is it intentional?

Technically intentional (see radar), but it /is/ kind of weird that the incomplete border is thicker than the failed-to-load border. Maybe we should change both. Or neither.

> > Source/WebCore/rendering/RenderImage.h:110
> > +    void paintIncompleteImageOutline(PaintInfo&, const LayoutPoint&, const LayoutUnit&);
> 
> shouldn't this paint function be const?

Almost certainly.

[Tim Horton]

It sort of looks like the tests got off-by-one?

[EWS Watchlist]

Comment on attachment 342717 [details]
Patch

Attachment 342717 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8185401

New failing tests:
http/tests/images/loading-image-border.html

[EWS Watchlist]

Created attachment 342771 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Tim Horton]

Created attachment 343218 [details]
Patch

[EWS Watchlist]

Comment on attachment 343218 [details]
Patch

Attachment 343218 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8274643

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 343222 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 343218 [details]
Patch

Attachment 343218 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8274630

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 343223 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 343218 [details]
Patch

Attachment 343218 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8276262

New failing tests:
imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.html

[EWS Watchlist]

Created attachment 343237 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Wenson Hsieh]

Comment on attachment 343218 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343218&action=review

> Source/WebCore/page/Settings.yaml:755
> +  initial: false

Should we trigger a repaint here when the value changes? (Probably not that important though, since our client is only going to enable this from the get-go and not fiddle with it later.)

[Anders Carlsson]

Comment on attachment 343218 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343218&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:1266
> +- (void)_setIncompleteImageBorderEnabled:(BOOL)incompleteImageBorderEnabled
> +{
> +    _preferences->setIncompleteImageBorderEnabled(incompleteImageBorderEnabled);
> +}
> +
> +- (BOOL)_incompleteImageBorderEnabled
> +{
> +    return _preferences->incompleteImageBorderEnabled();
> +}

Doesn't seem like this should be a preference.

[alan]

Comment on attachment 343218 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343218&action=review

> Source/WebCore/rendering/RenderImage.cpp:382
> +void RenderImage::paintIncompleteImageOutline(PaintInfo& paintInfo, const LayoutPoint& paintOffset, const LayoutUnit& borderWidth) const

Apparently you missed it from my previous review.
const LayoutPoint& paintOffset -> LayoutPoint 
const LayoutUnit& borderWidth -> LayoutUnit

> Source/WebCore/rendering/RenderImage.cpp:384
> +    LayoutSize contentSize = this->contentSize();

auto

[Tim Horton]

Created attachment 343361 [details]
Patch

[Tim Horton]

Created attachment 343392 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 343392 [details]
Patch

Clearing flags on attachment: 343392

Committed r233115: <https://trac.webkit.org/changeset/233115>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/41388828>