Bug 186608

Summary: MAP_JIT is not present for minimal simulator builds
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, commit-queue, darin, ltilve+ews
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ltilve-gtk-wk2-ews for gtk-wk2 none

Brent Fulgham
Reported 2018-06-13 15:10:20 PDT
When creating the minimal simulator variant for iOS, the necessary entitlements for MAP_JIT support were not included.
Attachments
Patch (1.20 KB, patch)
2018-06-14 12:15 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ltilve-gtk-wk2-ews for gtk-wk2 (2.82 MB, application/zip)
2018-06-18 22:22 PDT, Igalia-pontevedra EWS 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2018-06-14 12:15:28 PDT
Created attachment 342752 [details] Patch
Igalia-pontevedra EWS
Comment 2 2018-06-18 22:22:09 PDT
Comment on attachment 342752 [details] Patch Attachment 342752 [details] did not pass gtk-wk2-ews (gtk-wk2): Output: http://webkit-queues.webkit.org/results/8242581 New failing tests: http/tests/misc/canvas-pattern-from-incremental-image.html
Igalia-pontevedra EWS
Comment 3 2018-06-18 22:22:13 PDT
Created attachment 343020 [details] Archive of layout-test-results from ltilve-gtk-wk2-ews for gtk-wk2 The attached test failures were seen while running run-webkit-tests on the gtk-wk2-ews. Bot: ltilve-gtk-wk2-ews Port: gtk-wk2 Platform: Linux-4.16.0-0.bpo.1-amd64-x86_64-with-debian-9.4
Brent Fulgham
Comment 4 2018-06-19 08:28:01 PDT
(In reply to Igalia-pontevedra EWS from comment #3) > Created attachment 343020 [details] > Archive of layout-test-results from ltilve-gtk-wk2-ews for gtk-wk2 > > The attached test failures were seen while running run-webkit-tests on the > gtk-wk2-ews. > Bot: ltilve-gtk-wk2-ews Port: gtk-wk2 Platform: > Linux-4.16.0-0.bpo.1-amd64-x86_64-with-debian-9.4 These GTK tests can't be affected by an update to iOS entitlements.
WebKit Commit Bot
Comment 5 2018-06-19 08:56:03 PDT
Comment on attachment 342752 [details] Patch Clearing flags on attachment: 342752 Committed r232962: <https://trac.webkit.org/changeset/232962>
WebKit Commit Bot
Comment 6 2018-06-19 08:56:05 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-06-19 09:32:03 PDT
<rdar://problem/41252354>
Note You need to log in before you can comment on or make changes to this bug.