Bug 186602

Summary: [JSC] Remove cellLock in JSObject::convertContiguousToArrayStorage
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch saam: review+

Description Yusuke Suzuki 2018-06-13 11:17:07 PDT
Let’s consider whether it is safe, prove it’s safety, and remove it if we can!
Comment 1 Yusuke Suzuki 2018-06-14 03:15:41 PDT
Created attachment 342729 [details]
Patch
Comment 2 Yusuke Suzuki 2018-06-14 04:35:15 PDT
Created attachment 342731 [details]
Patch
Comment 3 Saam Barati 2018-06-14 10:46:01 PDT
Comment on attachment 342731 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342731&action=review

r=me

> Source/JavaScriptCore/runtime/JSObject.cpp:1350
> +    // Our following operations are sequentially executed by using storeStoreFence.

Our following => The mutator performs the following

> Source/JavaScriptCore/runtime/JSObject.cpp:1402
> +    WTF::storeStoreFence();

You only need this for mutatorShouldBeFenced, right?
Comment 4 Yusuke Suzuki 2018-06-16 09:38:59 PDT
Comment on attachment 342731 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342731&action=review

>> Source/JavaScriptCore/runtime/JSObject.cpp:1402
>> +    WTF::storeStoreFence();
> 
> You only need this for mutatorShouldBeFenced, right?

Yeah, we can guard this with it.
Comment 5 Yusuke Suzuki 2018-07-20 14:14:19 PDT
Committed r234065: <https://trac.webkit.org/changeset/234065>
Comment 6 Radar WebKit Bug Importer 2018-07-20 14:15:21 PDT
<rdar://problem/42444258>