Summary: | [JSC] Remove cellLock in JSObject::convertContiguousToArrayStorage | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Yusuke Suzuki
2018-06-13 11:17:07 PDT
Created attachment 342729 [details]
Patch
Created attachment 342731 [details]
Patch
Comment on attachment 342731 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342731&action=review r=me > Source/JavaScriptCore/runtime/JSObject.cpp:1350 > + // Our following operations are sequentially executed by using storeStoreFence. Our following => The mutator performs the following > Source/JavaScriptCore/runtime/JSObject.cpp:1402 > + WTF::storeStoreFence(); You only need this for mutatorShouldBeFenced, right? Comment on attachment 342731 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342731&action=review >> Source/JavaScriptCore/runtime/JSObject.cpp:1402 >> + WTF::storeStoreFence(); > > You only need this for mutatorShouldBeFenced, right? Yeah, we can guard this with it. Committed r234065: <https://trac.webkit.org/changeset/234065> |