Bug 186577 – Input form controls have white background in dark mode when they should not

• Component: Forms
• Status: RESOLVED FIXED

[Timothy Hatcher]

The input, textarea, and select have the wrong text and background color in dark mode.

<rdar://problem/39258325>

[Timothy Hatcher]

Created attachment 342603 [details]
Patch

[Megan Gardner]

Comment on attachment 342603 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342603&action=review

r=me with comments, unofficially

> Source/WebCore/ChangeLog:12
> +        (WebCore::featureWithValidIdent): Allow dark mode media query in user agenst stylesheets.

agenst?

> Source/WebCore/ChangeLog:17
> +        * css/html.css: Se color and background-color to semantic colors for input, textarea, and select.

Se?

> Source/WebCore/css/html.css:925
> +    /* While not clearest name, the inactiveborder system color maps to [NSColor controlBackgroundColor] on Mac. */

Should we just add an additional color with a more clear name rather than have all these comments?

[Tim Horton]

Comment on attachment 342603 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342603&action=review

> Source/WebCore/css/html.css:389
> +    /* While not clearest name, the inactiveborder system color maps to [NSColor controlBackgroundColor] on Mac. */

Probably should add -apple-system-control-background or something

[EWS Watchlist]

Comment on attachment 342603 [details]
Patch

Attachment 342603 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/8153561

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 342613 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[Timothy Hatcher]

Created attachment 342670 [details]
Patch

[Timothy Hatcher]

Created attachment 342671 [details]
Patch

[Megan Gardner]

Comment on attachment 342671 [details]
Patch

r=me, unofficial

[WebKit Commit Bot]

Comment on attachment 342671 [details]
Patch

Clearing flags on attachment: 342671

Committed r232806: <https://trac.webkit.org/changeset/232806>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

Comment on attachment 342671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342671&action=review

> Source/WebCore/DerivedSources.make:1026
> +ifeq ($(shell $(CC) -std=gnu++17 -x c++ -E -P -dM $(SDK_FLAGS) $(TARGET_TRIPLE_FLAGS) $(FRAMEWORK_FLAGS) $(HEADER_FLAGS) -include "wtf/Platform.h" /dev/null | grep ' WTF_PLATFORM_MAC ' | cut -d' ' -f3), 1)

Not entirely new to this patch, but can we avoid invoking the C preprocessor (with the exact same command line!) once per macro whose value we need?