| Summary: | Input form controls have white background in dark mode when they should not | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||||||
| Component: | Forms | Assignee: | Timothy Hatcher <timothy> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, ews-watchlist, megan_gardner, mitz, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||
| Priority: | P1 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Local Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Timothy Hatcher
2018-06-12 15:22:42 PDT
Created attachment 342603 [details]
Patch
Comment on attachment 342603 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342603&action=review r=me with comments, unofficially > Source/WebCore/ChangeLog:12 > + (WebCore::featureWithValidIdent): Allow dark mode media query in user agenst stylesheets. agenst? > Source/WebCore/ChangeLog:17 > + * css/html.css: Se color and background-color to semantic colors for input, textarea, and select. Se? > Source/WebCore/css/html.css:925 > + /* While not clearest name, the inactiveborder system color maps to [NSColor controlBackgroundColor] on Mac. */ Should we just add an additional color with a more clear name rather than have all these comments? Comment on attachment 342603 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342603&action=review > Source/WebCore/css/html.css:389 > + /* While not clearest name, the inactiveborder system color maps to [NSColor controlBackgroundColor] on Mac. */ Probably should add -apple-system-control-background or something Comment on attachment 342603 [details] Patch Attachment 342603 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/8153561 Number of test failures exceeded the failure limit. Created attachment 342613 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 342670 [details]
Patch
Created attachment 342671 [details]
Patch
Comment on attachment 342671 [details]
Patch
r=me, unofficial
Comment on attachment 342671 [details] Patch Clearing flags on attachment: 342671 Committed r232806: <https://trac.webkit.org/changeset/232806> All reviewed patches have been landed. Closing bug. Comment on attachment 342671 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342671&action=review > Source/WebCore/DerivedSources.make:1026 > +ifeq ($(shell $(CC) -std=gnu++17 -x c++ -E -P -dM $(SDK_FLAGS) $(TARGET_TRIPLE_FLAGS) $(FRAMEWORK_FLAGS) $(HEADER_FLAGS) -include "wtf/Platform.h" /dev/null | grep ' WTF_PLATFORM_MAC ' | cut -d' ' -f3), 1) Not entirely new to this patch, but can we avoid invoking the C preprocessor (with the exact same command line!) once per macro whose value we need? |