NetworkLoadChecker should not need to hard ref NetworkConnectionToWebProcess

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[youenn fablet]

This is unnecessary and if ping loads last for long, it can keep NetworkConnectionToWebProcess alive for more time than it should

[youenn fablet]

Created attachment 342772 [details]
Patch

[Alex Christensen]

Comment on attachment 342772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342772&action=review

Looks good to me.

> Source/WebCore/page/csp/ContentSecurityPolicy.h:172
> +    void setClient(ContentSecurityPolicyClient* client) { m_client = client; }

Ask Dan how he feels about this.

> Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:200
> +        contentSecurityPolicy->setClient(client);
> +        bool isAllowed = isAllowedByContentSecurityPolicy(request);
> +        contentSecurityPolicy->setClient(nullptr);
> +        if (!isAllowed) {

This definitely has room for improvement.

[youenn fablet]

Created attachment 343742 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 343742 [details]
Patch for landing

Clearing flags on attachment: 343742

Committed r233277: <https://trac.webkit.org/changeset/233277>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/41542890>