Bug 18655

Summary: [XHR] OnProgress needs more test case
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: XMLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Add 5 test cases darin: review+

Julien Chaffraix
Reported 2008-04-21 07:35:38 PDT
As mentioned in bug13596, we need more test case about onprogress event handler. On the top of my head: - addEventListener("progress", mycallback, XXX) should work - add checks for both interfaces (LSProgressEvent and ProgressEvent) - calling abort() should reset m_receivedLength - ...
Attachments
Add 5 test cases (11.99 KB, patch)
2008-05-30 16:29 PDT, Julien Chaffraix 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2008-05-30 16:29:50 PDT
Created attachment 21444 [details] Add 5 test cases
Darin Adler
Comment 2 2008-05-30 17:36:21 PDT
Comment on attachment 21444 [details] Add 5 test cases Nice! I love test cases!
Julien Chaffraix
Comment 3 2008-06-02 13:49:15 PDT
Committed in r34320.
Alexey Proskuryakov
Comment 4 2015-01-20 13:51:39 PST
Comment on attachment 21444 [details] Add 5 test cases View in context: https://bugs.webkit.org/attachment.cgi?id=21444&action=review > LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html:35 > +// If content length is not given, it should not be called > +req.onprogress = onProgressFailed; > +req.open("GET", "resources/noContentLength.asis", false); > +req.send(null); This test seems wrong, there is no reason to not fire the progress event for responses with chunked encoding. I'll fix. > LayoutTests/http/tests/xmlhttprequest/resources/noContentLength.asis:1 > +<html> This is not a properly formatted .asis file. It makes Apache return an empty response with "Content-Length: 0".
Note You need to log in before you can comment on or make changes to this bug.