Bug 186521

Summary: [webkitpy] PHP7.2 support on Debian platforms
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Tools / TestsAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, lforschler, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Philippe Normand
Reported 2018-06-11 06:53:18 PDT
.
Attachments
Patch (6.22 KB, patch)
2018-06-11 06:56 PDT, Philippe Normand 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2018-06-11 06:56:42 PDT
Created attachment 342426 [details] Patch
Michael Catanzaro
Comment 2 2018-06-11 07:11:18 PDT
Comment on attachment 342426 [details] Patch How does the new .conf file get used...?
Philippe Normand
Comment 3 2018-06-11 07:23:41 PDT
_apache_config_file_name_for_platform() in base.py returns the conf filename.
Michael Catanzaro
Comment 4 2018-06-11 07:24:55 PDT
Comment on attachment 342426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342426&action=review > Tools/Scripts/webkitpy/port/base.py:-1256 > - return "-php7.1" I missed that there was already support for 7.1. OK then!
Philippe Normand
Comment 5 2018-06-11 07:28:23 PDT
Committed r232711: <https://trac.webkit.org/changeset/232711>
Radar WebKit Bug Importer
Comment 6 2018-06-11 07:29:21 PDT
<rdar://problem/41003560>
Note You need to log in before you can comment on or make changes to this bug.