Summary: | Errors/warnings in Inspector should be visible outside of Resources | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Lilek <dev+webkit> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Adam Roben (:aroben) <aroben> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aroben, timothy | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Matt Lilek
2008-04-20 21:51:14 PDT
I think we could do something similar to Firebug/Xcode and put an error/warning count in the status bar. *** Bug 19029 has been marked as a duplicate of this bug. *** Created attachment 21144 [details]
patch v1 with ChangeLog
Created attachment 21145 [details] screenshot with attachment 21144 [details] applied I think ideally we'd show the error/warning count all the way on the right. But I couldn't figure out how to do that and make the DOM breadcrumb aware of the space taken up by the count. Maybe Tim will know how to do this. Comment on attachment 21144 [details]
patch v1 with ChangeLog
I forgot to include the changes to localizedStrings.js in this patch, but I've fixed that locally.
Hmm. I agree showing the all the way to the right would be best. So ElementsPanel.js:517: function crumbsAreSmallerThanContainer() { var rightPadding = 20; return ((crumbs.totalOffsetLeft + crumbs.offsetWidth + rightPadding) < window.innerWidth); } That rightPadding value could be dynamic based on the size of the error/waring count container. Comment on attachment 21144 [details]
patch v1 with ChangeLog
I have a revised patch to put the counts on the right of the status bar.
Landed in r33525. |