Bug 18650

Summary: Errors/warnings in Inspector should be visible outside of Resources
Product: WebKit Reporter: Matt Lilek <dev+webkit>
Component: Web Inspector (Deprecated)Assignee: Adam Roben (:aroben) <aroben>
Severity: Normal CC: aroben, timothy
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
patch v1 with ChangeLog
screenshot with attachment 21144 applied none

Description Matt Lilek 2008-04-20 21:51:14 PDT
I don't know if there is already something in mind for this, but there should definitely be some sort of visual indication of errors on the page in the inspector (Syntax errors, undefined values, etc) without looking at the Resources pane.  Perhaps the icon on the console button could be red (and then switch back to black/blue until another error occurs)?
Comment 1 Adam Roben (:aroben) 2008-04-20 22:13:45 PDT
I think we could do something similar to Firebug/Xcode and put an error/warning count in the status bar.
Comment 2 Adam Roben (:aroben) 2008-05-13 08:27:31 PDT
*** Bug 19029 has been marked as a duplicate of this bug. ***
Comment 3 Adam Roben (:aroben) 2008-05-13 08:27:48 PDT

Comment 4 Adam Roben (:aroben) 2008-05-14 17:31:49 PDT
Created attachment 21144 [details]
patch v1 with ChangeLog
Comment 5 Adam Roben (:aroben) 2008-05-14 17:32:13 PDT
Created attachment 21145 [details]
screenshot with attachment 21144 [details] applied
Comment 6 Adam Roben (:aroben) 2008-05-14 17:32:48 PDT
I think ideally we'd show the error/warning count all the way on the right. But I couldn't figure out how to do that and make the DOM breadcrumb aware of the space taken up by the count. Maybe Tim will know how to do this.
Comment 7 Adam Roben (:aroben) 2008-05-14 17:37:13 PDT
Comment on attachment 21144 [details]
patch v1 with ChangeLog

I forgot to include the changes to localizedStrings.js in this patch, but I've fixed that locally.
Comment 8 Timothy Hatcher 2008-05-14 18:49:26 PDT
Hmm. I agree showing the all the way to the right would be best.

So ElementsPanel.js:517:

        function crumbsAreSmallerThanContainer()
            var rightPadding = 20;
            return ((crumbs.totalOffsetLeft + crumbs.offsetWidth + rightPadding) < window.innerWidth);

That rightPadding value could be dynamic based on the size of the error/waring count container.
Comment 9 Timothy Hatcher 2008-05-16 10:40:08 PDT
Comment on attachment 21144 [details]
patch v1 with ChangeLog

I have a revised patch to put the counts on the right of the status bar.
Comment 10 Timothy Hatcher 2008-05-16 13:48:41 PDT
Landed in r33525.