|Summary:||REGRESSION(macOS Mojave): move-by-word-visually-inline-block-positioned-element.html fails|
|Product:||WebKit||Reporter:||Ryosuke Niwa <rniwa>|
|Component:||HTML Editing||Assignee:||Ryosuke Niwa <rniwa>|
|Severity:||Normal||CC:||ap, koivisto, megan_gardner, webkit-bug-importer, wenson_hsieh, zalan|
|Version:||WebKit Nightly Build|
Description Ryosuke Niwa 2018-06-07 21:37:44 PDT
The layout test fails on macOS Mojave.
Comment 3 Megan Gardner 2018-06-08 00:08:32 PDT
Wow, that’s one crazy bug! R=me, unofficially.
Comment 4 Ryosuke Niwa 2018-06-08 00:47:43 PDT
Comment on attachment 342244 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=342244&action=review > Source/WebCore/ChangeLog:32 > + wordBreakIteratorForMaxOffsetBoundary with visible position at offset 0 of "world", it thiss line and return nullptr. It should read "it skip this line and return nullptr."
Comment 5 Alexey Proskuryakov 2018-06-08 09:04:18 PDT
Great work! Is it possible to add a test that verifies this bug fix in a more straightforward manner, and maybe even extends testing in similar edge cases? Seems like we got lucky that a mostly unrelated test caught this.
Comment 6 Ryosuke Niwa 2018-06-08 13:06:04 PDT
(In reply to Alexey Proskuryakov from comment #5) > Great work! > > Is it possible to add a test that verifies this bug fix in a more > straightforward manner, and maybe even extends testing in similar edge > cases? Seems like we got lucky that a mostly unrelated test caught this. I wouldn't say we got lucky since the failing test basically tests every word movement across divs with variety position values in order to catch exactly like the bug like this. Having said that, I can add a new test which tests this exact failure although it would still require macOS Mojave to test it. I'm not certain adding a new mostly redundant test like that is useful though...
Comment 7 Alexey Proskuryakov 2018-06-08 13:29:58 PDT
Sounds like it would not be very useful given that.
Comment 8 Ryosuke Niwa 2018-06-08 13:31:03 PDT
(In reply to Alexey Proskuryakov from comment #7) > Sounds like it would not be very useful given that. Okay. I'll land the patch as is then.
Comment 9 Ryosuke Niwa 2018-06-08 13:36:11 PDT
Committed r232635: <https://trac.webkit.org/changeset/232635>