Bug 186395

Summary: REGRESSION (r232544): [iOS] TestWebKitAPI.WebKit.OverrideLayoutSizeChangesDuringAnimatedResizeSucceed is failing
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, realdawei, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186130
Attachments:
Description Flags
Patch none

Ryan Haddad
Reported 2018-06-07 09:00:25 PDT
The following API test is failing after https://trac.webkit.org/changeset/232544/webkit TestWebKitAPI.WebKit.OverrideLayoutSizeChangesDuringAnimatedResizeSucceed /Volumes/Data/slave/ios-simulator-11-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:215 Value of: 100 Expected: innerWidth Which is: 200 /Volumes/Data/slave/ios-simulator-11-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:216 Value of: 200 Expected: innerHeight Which is: 50 https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20%28Tests%29/builds/5419/steps/run-api-tests/logs/stdio
Attachments
Patch (2.23 KB, patch)
2018-06-07 11:45 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-06-07 09:32:20 PDT
Heh, that makes sense. I should be able to fix by sprinkling some doAfterNextPresentationUpdate in there.
Tim Horton
Comment 2 2018-06-07 09:32:44 PDT
(In the test)
Radar WebKit Bug Importer
Comment 3 2018-06-07 11:09:52 PDT
<rdar://problem/40902427>
Tim Horton
Comment 4 2018-06-07 11:45:36 PDT
Created attachment 342195 [details] Patch
WebKit Commit Bot
Comment 5 2018-06-07 12:17:45 PDT
Comment on attachment 342195 [details] Patch Clearing flags on attachment: 342195 Committed r232593: <https://trac.webkit.org/changeset/232593>
WebKit Commit Bot
Comment 6 2018-06-07 12:17:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.