Bug 186380 – [Xcode] Opt out of the New Build System

• Component: Tools / Tests
• Status: RESOLVED FIXED

In Xcode 10 beta 1, the New Build System is used by default. Until all projects in the stack are building successfully with the New Build System, we should opt out of using it.

For command-line builds, I think this can be done by changing webkitdirs.pm to include -UseNewBuildSystem=NO in the xcodebuild command-line.

For building from within Xcode, I think this can be done by changing the WebKit workspace at the root of the source tree.

People opening individual projects in Xcode, or using their own workspaces, will need to change the project or workspace settings to select the Legacy Build System.

Created attachment 342109 [details]
Use the Legacy Build System in the workspace and in command-line builds

[WebKit Commit Bot]

Comment on attachment 342109 [details]
Use the Legacy Build System in the workspace and in command-line builds

Clearing flags on attachment: 342109

Committed r232573: <https://trac.webkit.org/changeset/232573>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40881265>

[Darin Adler]

(In reply to mitz from comment #0)
> In Xcode 10 beta 1, the New Build System is used by default. Until all
> projects in the stack are building successfully with the New Build System,
> we should opt out of using it.

Just curious: Which projects don’t build successfully with it?

[Jonathan Bedard]

(In reply to Darin Adler from comment #5)
> (In reply to mitz from comment #0)
> > In Xcode 10 beta 1, the New Build System is used by default. Until all
> > projects in the stack are building successfully with the New Build System,
> > we should opt out of using it.
> 
> Just curious: Which projects don’t build successfully with it?

WebCore and WebKit are the big ones, but I think WebInspector has issues as well.

[Darin Adler]

(In reply to Jonathan Bedard from comment #6)
> WebCore and WebKit are the big ones, but I think WebInspector has issues as
> well.

Is someone working on that, or are we putting it off?

[Jonathan Bedard]

(In reply to Darin Adler from comment #7)
> (In reply to Jonathan Bedard from comment #6)
> > WebCore and WebKit are the big ones, but I think WebInspector has issues as
> > well.
> 
> Is someone working on that, or are we putting it off?

I think we're still determining who will be doing this. For the time being, we are putting it off, but I don't think we will be able to get away with pushing it back much farther than September or October.

(In reply to Darin Adler from comment #5)
> (In reply to mitz from comment #0)
> > In Xcode 10 beta 1, the New Build System is used by default. Until all
> > projects in the stack are building successfully with the New Build System,
> > we should opt out of using it.
> 
> Just curious: Which projects don’t build successfully with it?

Last I tried, JavaScriptCore was the first project in the stack to fail to build.

I should file a bug here to track that (I want it to be linked to the Apple-internal bug and I was too lazy to find that one last night).