Bug 186378

Summary:

[Win][MiniBrowser] Remove gMainWindow global variable

Product:

WebKit

Reporter:

Fujii Hironori <Hironori.Fujii>

Component:

Tools / Tests

Assignee:

Fujii Hironori <Hironori.Fujii>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, lforschler, pvollan, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

184770

Attachments:

Description	Flags
Patch	none
Patch	none

Description Fujii Hironori 2018-06-06 19:27:17 PDT

[Win][MiniBrowser] Remove gMainWindow global variable

Comment 1 Fujii Hironori 2018-06-06 19:47:06 PDT

Created attachment 342107 [details]
Patch

Comment 2 Ryosuke Niwa 2018-06-06 22:33:31 PDT

Comment on attachment 342107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342107&action=review

> Tools/MiniBrowser/win/Common.cpp:139
> +            int strLen = GetWindowText(GetDlgItem(hDlg, IDC_AUTH_USER), str, 256);

Can we use WTF_ARRAY_LENGTH or sizeof(str) / sizeof(*str) or std::size instead of hard-coding 256 twice?

> Tools/MiniBrowser/win/Common.cpp:143
> +            strLen = GetWindowText(GetDlgItem(hDlg, IDC_AUTH_PASSWORD), str, 256);

Ditto.

Comment 3 Fujii Hironori 2018-06-06 23:09:38 PDT

Thank you very much! I will fix them.

Comment 4 Fujii Hironori 2018-06-06 23:19:48 PDT

Created attachment 342124 [details]
Patch

Comment 5 Fujii Hironori 2018-06-06 23:26:08 PDT

Committed r232574: <https://trac.webkit.org/changeset/232574>

Comment 6 Radar WebKit Bug Importer 2018-06-06 23:27:16 PDT

<rdar://problem/40882765>