Summary: | Crash in lambda function WTF::Function<void ()>::CallableWrapper<WebKit::DisplayLink::displayLinkCallback | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, commit-queue, thorton, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Per Arne Vollan
2018-06-06 16:32:50 PDT
Created attachment 342095 [details]
Patch
Comment on attachment 342095 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342095&action=review r=me, if EWS is satisfied. > Source/WebKit/UIProcess/mac/DisplayLink.cpp:101 > + RunLoop::main().dispatch([weakPtr = webPageProxy->createWeakPtr()] { You should be able to use "weakPtr = makeWeakPtr(*webPageProxy)" (In reply to Brent Fulgham from comment #3) > Comment on attachment 342095 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342095&action=review > > r=me, if EWS is satisfied. > > > Source/WebKit/UIProcess/mac/DisplayLink.cpp:101 > > + RunLoop::main().dispatch([weakPtr = webPageProxy->createWeakPtr()] { > > You should be able to use "weakPtr = makeWeakPtr(*webPageProxy)" It seems the WebPageProxy class does not have the method weakPtrFactory() which appears to be needed to do this. Thanks for reviewing! Comment on attachment 342095 [details] Patch Clearing flags on attachment: 342095 Committed r232564: <https://trac.webkit.org/changeset/232564> All reviewed patches have been landed. Closing bug. |