Bug 186358

Summary:

Remove unused debug mode conditions

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, ews-watchlist, realdawei, ryanhaddad, wilander, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=186603

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Archive of layout-test-results from ews200 for win-future	none
Patch	none

Brent Fulgham

Reported 2018-06-06 11:34:28 PDT

Remove unused code paths from ITP debug mode now that we've settled on final behavior.

Attachments
Patch (2.71 KB, patch) 2018-06-06 11:50 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.25 MB, application/zip) 2018-06-06 13:35 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews200 for win-future (12.79 MB, application/zip) 2018-06-06 15:36 PDT, EWS Watchlist	no flags	Details
Patch (15.04 KB, patch) 2018-06-06 17:18 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2018-06-06 11:50:45 PDT

Created attachment 342068 [details] Patch

Brent Fulgham

Comment 2 2018-06-06 11:51:05 PDT

<rdar://problem/39117121>

EWS Watchlist

Comment 3 2018-06-06 13:35:09 PDT

Comment on attachment 342068 [details] Patch Attachment 342068 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/8035859 New failing tests: http/tests/resourceLoadStatistics/non-prevalent-resources-can-access-cookies-in-a-third-party-context.html http/tests/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction.html http/tests/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html

EWS Watchlist

Comment 4 2018-06-06 13:35:10 PDT

Created attachment 342079 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

EWS Watchlist

Comment 5 2018-06-06 15:36:09 PDT

Comment on attachment 342068 [details] Patch Attachment 342068 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8038239 New failing tests: http/tests/preload/onload_event.html

EWS Watchlist

Comment 6 2018-06-06 15:36:20 PDT

Created attachment 342086 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Brent Fulgham

Comment 7 2018-06-06 17:18:46 PDT

Created attachment 342098 [details] Patch

John Wilander

Comment 8 2018-06-06 19:44:39 PDT

Looks good to me. This change should be very simple and mostly be touching test expectations, which it is.

zalan

Comment 9 2018-06-07 09:48:07 PDT

Comment on attachment 342098 [details] Patch rs=me

Brent Fulgham

Comment 10 2018-06-07 10:05:13 PDT

Committed r232585: <https://trac.webkit.org/changeset/232585>