Bug 186319

Summary:

Adjust compile and runtime flags to match shippable state of features

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, keith_miller, mark.lam, msaboff, realdawei, rniwa, saam, samuel_white

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews114 for mac-sierra	none
Patch	none
Patch	none
Patch for landing	bfulgham: commit-queue+

Brent Fulgham

Reported 2018-06-05 13:32:43 PDT

This patch revises the compile time and runtime state for various features to match their suitability for end-user releases. We want to disable (at compile time) on all iOS/macOS platforms: (1) Input Type - Color (2) Input Type - Color (Popover) We want to compile code for the following features, but have them turned off by default (for all iOS/macOS platforms): (1) CSS Animations (Level 2) (2) Legacy EME (3) INTL_NUMBER_FORMAT_TO_PARTS (4) INTL_PLURAL_RULES (5) Server Timing API (6) WebGL2 (7) WebGPU (8) WebAssembly Streaming API (9) Web Animations (9) WebVR

Attachments
Patch (19.75 KB, patch) 2018-06-05 13:51 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (3.01 MB, application/zip) 2018-06-05 15:12 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.60 MB, application/zip) 2018-06-05 15:31 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-sierra (3.74 MB, application/zip) 2018-06-05 16:05 PDT, EWS Watchlist	no flags	Details
Patch (455.50 KB, patch) 2018-06-05 16:08 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch (595.68 KB, patch) 2018-06-05 16:21 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch for landing (5.63 KB, patch) 2018-06-06 10:55 PDT, Brent Fulgham	bfulgham: commit-queue+	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2018-06-05 13:33:00 PDT

<rdar://problem/40352045>

Brent Fulgham

Comment 2 2018-06-05 13:51:37 PDT

Created attachment 341991 [details] Patch

EWS Watchlist

Comment 3 2018-06-05 15:12:00 PDT

Comment on attachment 341991 [details] Patch Attachment 341991 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/8016786 New failing tests: imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application.html fast/css/read-only-read-write-input-basics.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/valueMode.html imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly.html accessibility/roles-exposed.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/color.html imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate.html fast/forms/color/input-appearance-color.html fast/forms/color/input-value-sanitization-color.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state.html fast/css/pseudo-visited-background-color-on-input.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/selection.html accessibility/color-well.html imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput.html imported/w3c/web-platform-tests/html/dom/reflection-forms.html fast/forms/color/color-setrangetext.html fast/selectors/read-only-read-write-input-basics.html

EWS Watchlist

Comment 4 2018-06-05 15:12:02 PDT

Created attachment 341998 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-06-05 15:31:48 PDT

Comment on attachment 341991 [details] Patch Attachment 341991 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/8017323 New failing tests: imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application.html fast/css/read-only-read-write-input-basics.html fast/forms/color/color-setrangetext.html imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly.html fast/forms/color/input-value-sanitization-color.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/selection.html imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate.html fast/forms/color/input-color-onchange-event.html fast/forms/color/input-appearance-color.html accessibility/roles-exposed.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state.html fast/css/pseudo-visited-background-color-on-input.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/valueMode.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/color.html fast/forms/color/input-color-readonly.html fast/selectors/read-only-read-write-input-basics.html accessibility/color-well.html imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput.html imported/w3c/web-platform-tests/html/dom/reflection-forms.html

EWS Watchlist

Comment 6 2018-06-05 15:31:50 PDT

Created attachment 341999 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-06-05 16:05:48 PDT

Comment on attachment 341991 [details] Patch Attachment 341991 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/8017872 New failing tests: imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application.html fast/css/read-only-read-write-input-basics.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/valueMode.html imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly.html accessibility/roles-exposed.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/color.html imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate.html fast/forms/color/input-appearance-color.html fast/forms/color/input-value-sanitization-color.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state.html fast/css/pseudo-visited-background-color-on-input.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/selection.html accessibility/color-well.html imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput.html fast/forms/color/color-setrangetext.html fast/selectors/read-only-read-write-input-basics.html

EWS Watchlist

Comment 8 2018-06-05 16:05:50 PDT

Created attachment 342000 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6

Brent Fulgham

Comment 9 2018-06-05 16:08:00 PDT

Created attachment 342001 [details] Patch

Brent Fulgham

Comment 10 2018-06-05 16:21:34 PDT

Created attachment 342002 [details] Patch

Brent Fulgham

Comment 11 2018-06-05 16:31:31 PDT

Committed r232526: <https://trac.webkit.org/changeset/232526>

Dawei Fenton (:realdawei)

Comment 12 2018-06-06 09:04:09 PDT

looks like this latest patch may have caused API test failures on Mac WK1 and WK2 Example of output: Timeout TestWebKitAPI.WebKit.InjectedBundleNodeHandleIsTextField https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/4902/steps/run-api-tests/logs/stdio