Bug 186212

Summary: Move tests in LayoutTests/editing to appropriate subdirectories
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: lforschler, realdawei, ryanhaddad, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Moves the tests wenson_hsieh: review+

Ryosuke Niwa
Reported 2018-06-01 16:57:39 PDT
Move tests in LayoutTests/editing to its subdirectories.
Attachments
Moves the tests (17.72 KB, patch)
2018-06-01 17:00 PDT, Ryosuke Niwa 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-06-01 17:00:06 PDT
Created attachment 341808 [details] Moves the tests
Wenson Hsieh
Comment 2 2018-06-01 17:02:29 PDT
Comment on attachment 341808 [details] Moves the tests rs=me
Ryosuke Niwa
Comment 3 2018-06-01 17:04:45 PDT
Committed r232430: <https://trac.webkit.org/changeset/232430>
Radar WebKit Bug Importer
Comment 4 2018-06-01 17:46:59 PDT
<rdar://problem/40740845>
Dawei Fenton (:realdawei)
Comment 5 2018-06-04 15:22:42 PDT
Looks like this caused a regression in the following test: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fselection%2Fsimple-line-layout-caret-is-gone.html Regressions: Unexpected text-only failures (1) editing/selection/simple-line-layout-caret-is-gone.html [ Failure ]
Ryosuke Niwa
Comment 6 2018-06-04 16:16:08 PDT
(In reply to David Fenton from comment #5) > Looks like this caused a regression in the following test: > > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=editing%2Fselection%2Fsimple-line-layout-caret- > is-gone.html > > Regressions: Unexpected text-only failures (1) > editing/selection/simple-line-layout-caret-is-gone.html [ Failure ] Looks like I forgot to move the platform specific results in that revision.
Ryosuke Niwa
Comment 7 2018-06-04 17:32:47 PDT
Fixed it in https://trac.webkit.org/changeset/232488.
Note You need to log in before you can comment on or make changes to this bug.