Summary: | [Cocoa] Web Automation: include browser name and version in listing for automation targets | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||
Component: | WebDriver | Assignee: | BJ Burg <bburg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, benjamin, cdumez, cgarcia, cmarcelo, darin, dbates, ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, saam, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
BJ Burg
2018-06-01 12:43:40 PDT
Created attachment 341803 [details]
Proposed Fix
Comment on attachment 341803 [details] Proposed Fix Attachment 341803 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7942045 New failing tests: http/tests/preload/onload_event.html Created attachment 341839 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 341803 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=341803&action=review > Source/WebKit/UIProcess/Cocoa/AutomationClient.h:58 > + String browserName() const override; > + String browserVersion() const override; final instead of override? > Source/WebKit/UIProcess/Cocoa/AutomationClient.mm:88 > + return [m_delegate.get() _processPoolBrowserNameForAutomation:m_processPool]; No need for the ".get()" here. > Source/WebKit/UIProcess/Cocoa/AutomationClient.mm:94 > + NSString *displayName = appBundle.infoDictionary[(__bridge NSString *)_kCFBundleDisplayNameKey]; > + NSString *readableName = appBundle.infoDictionary[(__bridge NSString *)kCFBundleNameKey]; > + return displayName ?: readableName; Seems a bit of a shame to compute the readableName when the displayName is non-null. Maybe omit the local variables? > Source/WebKit/UIProcess/Cocoa/AutomationClient.mm:100 > + return [m_delegate.get() _processPoolBrowserVersionForAutomation:m_processPool]; No need for the ".get()" here. Committed r232636: <https://trac.webkit.org/changeset/232636> |