Bug 18620 – Long hang under TextIterator::advance() when loading http://www.lsvd.de/

• Component: HTML Editing
• Status: RESOLVED FIXED

As soon as I click into the SEARCH (Suchen) field on the Website www.lsvd.de the Browser hangs it self up and is not responding anylonger.
When I do the same with the regular Safari Browser I can work on the website with no problems.

I have sent the system report to Apple and would have pasted into this text field but it was too long.

[Alexey Proskuryakov]

With a local debug build, I got a temporary freeze (for ~30 seconds) when opening the page, but not when clicking in the search field.

[Eric Seidel (no email)]

I can confirm ap's findings.  I don't see a hang when clicking the search field, but I do see one on load:

	0.0%	99.8%	Safari	0xb2776 [unknown]	
	0.0%	99.8%	AppKit	 NSApplicationMain	
	0.0%	99.8%	AppKit	  -[NSApplication run]	
	0.0%	99.8%	Safari	   0x7ae0 [105B]	
	0.0%	99.8%	AppKit	    -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:]	
	0.0%	99.8%	AppKit	     _DPSNextEvent	
	0.0%	99.8%	HIToolbox	      BlockUntilNextEventMatchingListInMode	
	0.0%	99.8%	HIToolbox	       ReceiveNextEventCommon	
	0.0%	99.8%	HIToolbox	        RunCurrentEventLoopInMode	
	0.0%	99.8%	CoreFoundation	         CFRunLoopRunInMode	
	0.0%	99.8%	CoreFoundation	          CFRunLoopRunSpecific	
	0.0%	99.8%	Foundation	           __NSFireTimer	
	0.0%	99.8%	Safari	            0x100840 [169B]	
	0.0%	99.8%	Safari	             0x26d90 [264B]	
	0.0%	99.8%	Safari	              0x27154 [unknown]	
	0.0%	99.8%	Safari	               0x27480 [421B]	
	0.0%	99.8%	WebKit	                -[WebHTMLView(WebDocumentPrivateProtocols) string]	
	0.0%	99.8%	WebKit	                 -[WebFrame(WebInternal) _stringForRange:]	
	0.0%	99.8%	WebCore	                  WebCore::plainTextToMallocAllocatedBuffer(WebCore::Range const*, unsigned int&)	
	0.0%	99.8%	WebCore	                   WebCore::TextIterator::TextIterator(WebCore::Range const*, bool, bool)	
	0.0%	99.8%	WebCore	                    WebCore::TextIterator::advance()	
	0.0%	99.8%	WebCore	                     WebCore::TextIterator::handleNonTextNode()	
	0.0%	99.8%	WebCore	                      WebCore::TextIterator::representNodeOffsetZero()	
	0.0%	99.8%	WebCore	                       WebCore::TextIterator::shouldRepresentNodeOffsetZero()	
	0.0%	76.0%	WebCore	                        WebCore::inSameLine(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&)	
	0.0%	76.0%	WebCore	                         WebCore::startOfLine(WebCore::VisiblePosition const&)	
	0.0%	76.0%	WebCore	                          _ZN7WebCoreL20startPositionForLineERKNS_15VisiblePositionE	
	0.0%	76.0%	WebCore	                           _ZN7WebCoreL36positionAvoidingFirstPositionInTableERKNS_15VisiblePositionE	
	0.0%	76.0%	WebCore	                            WebCore::VisiblePosition::previous(bool) const	
	3.4%	75.4%	WebCore	                             WebCore::previousVisuallyDistinctCandidate(WebCore::Position const&)	
	6.5%	31.2%	WebCore	                              WebCore::Position::previous(WebCore::EUsingComposedCharacters) const	


I'm not sure why Safari's asking for the text content of the page at load, but the TextIterator seems to have some trouble iterating through this large page. :)

[Justin Garcia]

(In reply to comment #2)
> I'm not sure why Safari's asking for the text content of the page at load, but
> the TextIterator seems to have some trouble iterating through this large page.

I believe it's for indexing.  I'll take a look at this...

[Justin Garcia]

Created attachment 25094 [details]
patch

[Darin Adler]

Comment on attachment 25094 [details]
patch

r=me

Could you add a test case?

[Justin Garcia]

(In reply to comment #5)
> (From update of attachment 25094 [details] [review])
> r=me
> 
> Could you add a test case?

Not currently.  There's no way to create a test that makes an explicit call to plainText or to a function that calls plainText with the kind of Range necessary to invoke this code.  Filed:

https://bugs.webkit.org/show_bug.cgi?id=22236

[Justin Garcia]

http://trac.webkit.org/changeset/38376