Summary: | Fix leak of AudioDeviceID array due to an early return in AudioDeviceMac::GetNumberDevices() | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||||
Component: | WebRTC | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, eric.carlson, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.chromium.org/p/webrtc/issues/detail?id=9348 | ||||||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2018-05-31 11:19:16 PDT
Created attachment 341679 [details]
Patch v1
Comment on attachment 341679 [details]
Patch v1
Can't we use std::make_unique?
(In reply to Alex Christensen from comment #3) > Comment on attachment 341679 [details] > Patch v1 > > Can't we use std::make_unique? I was aiming to change the code as little as possible, but yes we can! New patch forthcoming. Created attachment 341681 [details]
Patch v2
Created attachment 341684 [details]
Patch v3
Remove 'const' from 'numberDevices' since it used in an in-out context in AudioObjectGetPropertyData().
Comment on attachment 341684 [details] Patch v3 Clearing flags on attachment: 341684 Committed r232365: <https://trac.webkit.org/changeset/232365> All reviewed patches have been landed. Closing bug. |