Bug 186119 – Update expected results for BuildStepsConstructorTest

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Ryan Haddad]

Update expected results for BuildStepsConstructorTest, as these tests fail when run locally:

./steps_unittest.py
  import sets as _sets
..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................FFFFFFF...................................
======================================================================
FAIL: test_builder WinCairo 64-bit JSC Debug (Tests) (__main__.BuildStepsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./steps_unittest.py", line 586, in doTest
    self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps))
AssertionError: Missing expected result for builder: WinCairo 64-bit JSC Debug (Tests)
 Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'jscore-test']

======================================================================
FAIL: test_builder WinCairo 64-bit JSC Release (Tests) (__main__.BuildStepsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./steps_unittest.py", line 586, in doTest
    self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps))
AssertionError: Missing expected result for builder: WinCairo 64-bit JSC Release (Tests)
 Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'jscore-test']

======================================================================
FAIL: test_builder WinCairo 64-bit WKL Debug (Build) (__main__.BuildStepsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./steps_unittest.py", line 586, in doTest
    self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps))
AssertionError: Missing expected result for builder: WinCairo 64-bit WKL Debug (Build)
 Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit', 'archive-built-product', 'upload', 'transfer-to-s3', 'trigger']

======================================================================
FAIL: test_builder WinCairo 64-bit WKL Debug (Tests) (__main__.BuildStepsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./steps_unittest.py", line 586, in doTest
    self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps))
AssertionError: Missing expected result for builder: WinCairo 64-bit WKL Debug (Tests)
 Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'wincairo-requirements', 'layout-test', 'run-api-tests', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'archive-test-results', 'upload', 'MasterShellCommand']

======================================================================
FAIL: test_builder WinCairo 64-bit WKL Release (Build) (__main__.BuildStepsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./steps_unittest.py", line 586, in doTest
    self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps))
AssertionError: Missing expected result for builder: WinCairo 64-bit WKL Release (Build)
 Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit', 'archive-built-product', 'upload', 'transfer-to-s3', 'trigger']

======================================================================
FAIL: test_builder WinCairo 64-bit WKL Release (Tests) (__main__.BuildStepsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./steps_unittest.py", line 586, in doTest
    self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps))
AssertionError: Missing expected result for builder: WinCairo 64-bit WKL Release (Tests)
 Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'wincairo-requirements', 'layout-test', 'run-api-tests', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'archive-test-results', 'upload', 'MasterShellCommand']

======================================================================
FAIL: test_unnecessary_expected_results (__main__.BuildStepsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./steps_unittest.py", line 597, in test_unnecessary_expected_results
    self.assertTrue(builder in builders, "Builder %s doesn't exist, but has unnecessary expected results" % builder)
AssertionError: Builder WinCairo 64-Bit Release doesn't exist, but has unnecessary expected results

----------------------------------------------------------------------
Ran 764 tests in 0.025s

FAILED (failures=7)

[Ryan Haddad]

Created attachment 341626 [details]
Patch

[Ross Kirsling]

Oops, I didn't realize there were unit tests to verify each bot's steps -- thank you for doing this!

[WebKit Commit Bot]

Comment on attachment 341626 [details]
Patch

Clearing flags on attachment: 341626

Committed r232363: <https://trac.webkit.org/changeset/232363>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40696190>