Bug 186091

Summary: WebKit memory management: Safari jetsams on some websites when zooming and scrolling
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ggaren, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
ggaren: review+
patch
none
patch none

Description Antti Koivisto 2018-05-30 07:24:46 PDT
Summary:
Using the zoom function on a few websites is causing a crash of Safari

Steps to Reproduce:
Go on www.uk-koeln.de or www.huettenhospital.de and use the zoom function a few times in a short time.
Comment 1 Antti Koivisto 2018-05-30 07:25:05 PDT
<rdar://problem/36315010>
Comment 2 Antti Koivisto 2018-05-30 07:43:57 PDT
Created attachment 341572 [details]
patch
Comment 3 Geoffrey Garen 2018-05-30 10:02:27 PDT
Comment on attachment 341572 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341572&action=review

r=me

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2896
> -    
> +

Boo whitespace change.
Comment 4 Simon Fraser (smfr) 2018-05-30 10:59:34 PDT
Comment on attachment 341572 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341572&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:308
> +    return FloatRect(exposedRect.x() - horizontalChange / 2, exposedRect.y() - verticalChange / 2, exposedRect.width() + horizontalChange, exposedRect.height() + verticalChange);

Use FloatRect::expand()!
Comment 5 Antti Koivisto 2018-05-31 04:43:38 PDT
Created attachment 341657 [details]
patch
Comment 6 Antti Koivisto 2018-05-31 04:45:30 PDT
Created attachment 341658 [details]
patch
Comment 7 WebKit Commit Bot 2018-05-31 10:55:49 PDT
Comment on attachment 341658 [details]
patch

Clearing flags on attachment: 341658

Committed r232356: <https://trac.webkit.org/changeset/232356>
Comment 8 WebKit Commit Bot 2018-05-31 10:55:50 PDT
All reviewed patches have been landed.  Closing bug.