Bug 186084

Summary:

AX: Expose link rel type to voiceover

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none
patch	none

Description chris fleizach 2018-05-29 22:44:38 PDT

Expose rel type to voiceover so it can speak it

Comment 1 Radar WebKit Bug Importer 2018-05-29 22:44:50 PDT

<rdar://problem/40640871>

Comment 2 chris fleizach 2018-05-29 22:45:00 PDT

<rdar://problem/40562873>

Comment 3 chris fleizach 2018-05-29 22:52:37 PDT

Created attachment 341558 [details]
patch

Comment 4 James Craig 2018-05-30 01:53:17 PDT

I don't think WebKit should expose all these types to the platform APIs. It wouldn't make sense to have AT (VO/SC for Mac, VO/SC for iOS, Orca on Linux, etc) maintain their own representation of  the search engine instructions (nofollow, canonical),  rendering engine instructions (manifest, prefetch), or verbose microdata. 

Perhaps add a short whitelist for each of the few relevant types? It might be good to have WebKit localize these values, too.

https://html.spec.whatwg.org/#linkTypes
https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types

Likely candidates are:
- author
- bookmark 
- external
- help
- license
- next
- prev
- search

Deprecated but still useful:
- archives
- first
- index
- last
- up

Maybe:
- alternate (if the type attribute is set to a human readable value like PDF)

Comment 5 James Craig 2018-05-30 01:56:16 PDT

> It might be good to have WebKit localize these values, too.

To clarify, I'm suggesting WebKit expose *both* the raw machine value (e.g. "prev") and a localized equivalent (e.g. "Previous")

Comment 6 chris fleizach 2018-05-30 08:46:28 PDT

(In reply to James Craig from comment #5)
> > It might be good to have WebKit localize these values, too.
> 
> To clarify, I'm suggesting WebKit expose *both* the raw machine value (e.g.
> "prev") and a localized equivalent (e.g. "Previous")

Suggestion noted. I don’t think it makes sense to do that. It doesn’t have any value and restricts ability of screen reader platforms to communicate what they want to their users

Comment 7 chris fleizach 2018-05-30 08:52:03 PDT

Created attachment 341576 [details]
patch

Comment 8 WebKit Commit Bot 2018-05-30 18:21:21 PDT

Comment on attachment 341576 [details]
patch

Clearing flags on attachment: 341576

Committed r232326: <https://trac.webkit.org/changeset/232326>

Comment 9 WebKit Commit Bot 2018-05-30 18:21:22 PDT

All reviewed patches have been landed.  Closing bug.