Bug 186024

Summary: Modernize SVGRenderStyleDefs.h
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Sam Weinig 2018-05-27 13:00:45 PDT
Modernize SVGRenderStyleDefs.h
Comment 1 Sam Weinig 2018-05-27 13:51:35 PDT Comment hidden (obsolete)
Comment 2 EWS Watchlist 2018-05-27 13:54:17 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2018-05-27 17:41:09 PDT
Created attachment 341438 [details]
Patch
Comment 4 EWS Watchlist 2018-05-27 17:42:51 PDT
Attachment 341438 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/style/SVGRenderStyleDefs.h:50:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/rendering/style/SVGRenderStyleDefs.h:68:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 55 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Daniel Bates 2018-05-27 20:32:13 PDT
Comment on attachment 341438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341438&action=review

> Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp:61
> +AlignmentBaseline SVGTextLayoutEngineBaseline::dominantBaselineToAlignmentBaseline(bool isVerticalText, const RenderObject* textRenderer) const

This is fine as-is. Would be great to make textRenderer a const lvalue reference instead of a pointer and then remove at least the first ASSERT. This would be good to do in a follow up.

> Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp:100
>      default:

This is ok as-is. Would be great if we can remove the default case and let the compiler enforce the enum.
Comment 6 WebKit Commit Bot 2018-05-28 08:20:10 PDT
Comment on attachment 341438 [details]
Patch

Clearing flags on attachment: 341438

Committed r232246: <https://trac.webkit.org/changeset/232246>
Comment 7 WebKit Commit Bot 2018-05-28 08:20:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-05-28 08:21:34 PDT
<rdar://problem/40599402>