Bug 186024

Summary:

Modernize SVGRenderStyleDefs.h

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates, ews-watchlist, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Sam Weinig

Reported 2018-05-27 13:00:45 PDT

Modernize SVGRenderStyleDefs.h

Attachments
Patch (129.47 KB, patch) 2018-05-27 13:51 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (136.46 KB, patch) 2018-05-27 17:41 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2018-05-27 13:51:35 PDT Comment hidden (obsolete)

Created attachment 341429 [details] Patch

EWS Watchlist

Comment 2 2018-05-27 13:54:17 PDT Comment hidden (obsolete)

Attachment 341429 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/style/SVGRenderStyleDefs.h:50: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/SVGRenderStyleDefs.h:68: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 2 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 3 2018-05-27 17:41:09 PDT

Created attachment 341438 [details] Patch

EWS Watchlist

Comment 4 2018-05-27 17:42:51 PDT

Attachment 341438 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/style/SVGRenderStyleDefs.h:50: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/SVGRenderStyleDefs.h:68: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 2 in 55 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 5 2018-05-27 20:32:13 PDT

Comment on attachment 341438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341438&action=review > Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp:61 > +AlignmentBaseline SVGTextLayoutEngineBaseline::dominantBaselineToAlignmentBaseline(bool isVerticalText, const RenderObject* textRenderer) const This is fine as-is. Would be great to make textRenderer a const lvalue reference instead of a pointer and then remove at least the first ASSERT. This would be good to do in a follow up. > Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp:100 > default: This is ok as-is. Would be great if we can remove the default case and let the compiler enforce the enum.

WebKit Commit Bot

Comment 6 2018-05-28 08:20:10 PDT

Comment on attachment 341438 [details] Patch Clearing flags on attachment: 341438 Committed r232246: <https://trac.webkit.org/changeset/232246>

WebKit Commit Bot

Comment 7 2018-05-28 08:20:11 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2018-05-28 08:21:34 PDT

<rdar://problem/40599402>

Note You need to log in before you can comment on or make changes to this bug.