Bug 186017

Summary: [WTF] RandomDevice should be initialized inside std::call_once
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, dbates, don.olmstead, ews-watchlist, fpizlo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 186014    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch darin: review+

Yusuke Suzuki
Reported 2018-05-27 06:57:24 PDT
[WTF] RandomDevice should be initialized inside std::call_once
Attachments
Patch (1.57 KB, patch)
2018-05-27 06:58 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (1.68 KB, patch)
2018-06-26 19:04 PDT, Yusuke Suzuki 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-05-27 06:58:19 PDT
Created attachment 341420 [details] Patch
Alexey Proskuryakov
Comment 2 2018-05-31 11:46:39 PDT
Comment on attachment 341420 [details] Patch Marking r- to get out of review queue, as EWS is all red.
Yusuke Suzuki
Comment 3 2018-06-26 19:04:46 PDT
Created attachment 343674 [details] Patch
Don Olmstead
Comment 4 2018-06-28 12:33:03 PDT
Comment on attachment 343674 [details] Patch Informal review is that LGTM. Guessing this is something you're going to be doing across the codebase?
Darin Adler
Comment 5 2018-06-28 14:40:28 PDT
(In reply to Don Olmstead from comment #4) > Guessing this is something you're going to be doing across the codebase? I think only in code that is supposed to be safe for use from multiple threads, which is a small faction of all WebKit code.
Darin Adler
Comment 6 2018-06-28 14:41:33 PDT
Comment on attachment 343674 [details] Patch Since I expect this to come up repeatedly I wonder if there is a cleaner idiom for this. If some way we find we can afford to pay the locking cost on Apple’s platforms it would be nice to be able to quickly remove all of this code.
Darin Adler
Comment 7 2018-06-28 14:53:46 PDT
Maybe the elegant way to do it is to define a different NeverDestroyed variant that automatically includes the once_flag and the laziness and does this all. Then that can be used only on platforms where we turn off the compiler’s built-in locking. On other platforms it can possibly even be a typedef for the plain old NeverDestroyed.
Yusuke Suzuki
Comment 8 2018-07-01 21:17:07 PDT
(In reply to Darin Adler from comment #7) > Maybe the elegant way to do it is to define a different NeverDestroyed > variant that automatically includes the once_flag and the laziness and does > this all. Then that can be used only on platforms where we turn off the > compiler’s built-in locking. On other platforms it can possibly even be a > typedef for the plain old NeverDestroyed. Yeah, that sounds fancy.
Yusuke Suzuki
Comment 9 2018-07-01 21:24:38 PDT
Committed r233415: <https://trac.webkit.org/changeset/233415>
Radar WebKit Bug Importer
Comment 10 2018-07-01 21:25:18 PDT
<rdar://problem/41709074>
Note You need to log in before you can comment on or make changes to this bug.