Bug 186013

Summary: [Baseline] Merge JITPropertyAccess, JITArithmetic, JITOpcodes, and JITCall to JIT
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: NEW    
Severity: Normal CC: achristensen, ews-watchlist, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yusuke Suzuki
Reported 2018-05-26 08:37:53 PDT
[Baseline] Merge JITPropertyAccess, JITArithmetic, JITOpcodes, and JITCall to JIT
Attachments
Patch (621.01 KB, patch)
2018-05-26 08:40 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (616.69 KB, patch)
2018-05-29 13:18 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-05-26 08:40:59 PDT
Created attachment 341398 [details] Patch
Yusuke Suzuki
Comment 2 2018-05-29 13:18:47 PDT
Created attachment 341507 [details] Patch
Yusuke Suzuki
Comment 3 2018-05-29 13:19:16 PDT
Rebaselined. Ready for review.
Saam Barati
Comment 4 2018-05-29 14:17:37 PDT
Comment on attachment 341507 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341507&action=review > Source/JavaScriptCore/ChangeLog:8 > + It is hard to check whether the given functionality is implemented in 32bit / 64bit, Do you really believe that this is hard to do? Does this patch do anything besides copy old implementation into this new file?
Yusuke Suzuki
Comment 5 2018-05-30 08:08:26 PDT
(In reply to Saam Barati from comment #4) > Comment on attachment 341507 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=341507&action=review > > > Source/JavaScriptCore/ChangeLog:8 > > + It is hard to check whether the given functionality is implemented in 32bit / 64bit, > > Do you really believe that this is hard to do? > Yes, for example, we have bunch of #if USE(JSVALUE64) / USE(JSVALUE32_64) in each file. Small ifdefs are consolidated into JIT.cpp. And large ifdef gaurds are removed and code is moved into JIT32_64.cpp / JIT64.cpp. Small ifdefs in functions are typically doing the same things (like, defining registers), they can be later removed easily in a batch styled manner. And this code structure is completely the same to DFG, it is easy to find code. > Does this patch do anything besides copy old implementation into this new > file? Yes, this patch just copies the implementations into these files.
Alex Christensen
Comment 6 2021-11-01 12:16:36 PDT
Comment on attachment 341507 [details] Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.
Note You need to log in before you can comment on or make changes to this bug.