Comment on attachment 341329[details]
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=341329&action=review
r=me with fixes.
> Source/JavaScriptCore/runtime/ErrorInstance.cpp:216
> + for (const auto& frame : *m_stackTrace.get()) {
> + if (!frame.isMarked()) {
> + computeErrorInfo(vm);
> + return;
> + }
> + }
Technically, one could infer backwards using svn blame to figure out why you're doing this here, but I think this action is sufficiently detached from the motivation behind it that it's worth adding a comment here to explain why you're doing this.
> Source/JavaScriptCore/tools/JSDollarVM.cpp:1693
> + {
> + return JSValue::encode(jsNumber(exec->vm().heap.globalObjectCount()));
> + }
Please fix indentation.
> Source/JavaScriptCore/tools/JSDollarVM.cpp:1851
> + addFunction(vm, "globalObjectCount", functionGlobalObjectCount, 0);
This functionality is not documented in the ChangeLog. Please add a short ChangeLog comment for this.
Comment on attachment 341329[details]
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=341329&action=review>> Source/JavaScriptCore/runtime/ErrorInstance.cpp:216
>> + }
>
> Technically, one could infer backwards using svn blame to figure out why you're doing this here, but I think this action is sufficiently detached from the motivation behind it that it's worth adding a comment here to explain why you're doing this.
Done.
>> Source/JavaScriptCore/tools/JSDollarVM.cpp:1693
>> + }
>
> Please fix indentation.
Fixed.
>> Source/JavaScriptCore/tools/JSDollarVM.cpp:1851
>> + addFunction(vm, "globalObjectCount", functionGlobalObjectCount, 0);
>
> This functionality is not documented in the ChangeLog. Please add a short ChangeLog comment for this.
Sure.
Created attachment 341501[details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 341503[details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 341505[details]
Archive of layout-test-results from ews115 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 341511[details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 341517[details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 341518[details]
Archive of layout-test-results from ews115 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 341532[details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 341551[details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 341554[details]
Archive of layout-test-results from ews114 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 341555[details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 341559[details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Wow, nice catch! I've seen this kind of global object leak in the wild many times but never managed to get to a handle on why it was happening. Great job Keith :)
Created attachment 341581[details]
Archive of layout-test-results from ews101 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 341586[details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 341587[details]
Archive of layout-test-results from ews116 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 341596[details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 341605[details]
Patch
Rejecting attachment 341605[details] from commit-queue.
Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 341605, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit
Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=341605&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=185996&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 341605 from bug 185996.
Fetching: https://bugs.webkit.org/attachment.cgi?id=341605
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Committing to http://svn.webkit.org/repository/webkit/trunk ...
A LayoutTests/js/error-should-not-strong-reference-global-object-expected.txt
A LayoutTests/js/error-should-not-strong-reference-global-object.html
M JSTests/stress/error-stack-trace-limit.js
M JSTests/stress/tail-call-recognize.js
M LayoutTests/ChangeLog
M Source/JavaScriptCore/ChangeLog
ERROR from SVN:
Item is out of date: File '/trunk/Source/JavaScriptCore/ChangeLog' is out of date
W: 466f13ea89b04910f2dbbb1a100261fdc8c0f7ee and refs/remotes/origin/master differ, using rebase:
:040000 040000 cf518dfd93ade718501e090e685da3e925ebd9f3 3c3963b79d24e56cf41c16584fc6211b7ef0fedd M JSTests
:040000 040000 7d103a229083572c8ff15414938b927a37e9ca76 f18c07763a24669afabd3f06d812b4fe0a4ba939 M LayoutTests
:040000 040000 80558f669921094dc647cf8800ffee7193fba2e9 ad7be83ba3ab9b72e380faabc7b3b6d96bc4bab3 M Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Committing to http://svn.webkit.org/repository/webkit/trunk ...
A LayoutTests/js/error-should-not-strong-reference-global-object-expected.txt
A LayoutTests/js/error-should-not-strong-reference-global-object.html
M JSTests/stress/error-stack-trace-limit.js
M JSTests/stress/tail-call-recognize.js
M LayoutTests/ChangeLog
M Source/JavaScriptCore/ChangeLog
ERROR from SVN:
Item is out of date: File '/trunk/Source/JavaScriptCore/ChangeLog' is out of date
W: 466f13ea89b04910f2dbbb1a100261fdc8c0f7ee and refs/remotes/origin/master differ, using rebase:
:040000 040000 cf518dfd93ade718501e090e685da3e925ebd9f3 3c3963b79d24e56cf41c16584fc6211b7ef0fedd M JSTests
:040000 040000 7d103a229083572c8ff15414938b927a37e9ca76 f18c07763a24669afabd3f06d812b4fe0a4ba939 M LayoutTests
:040000 040000 80558f669921094dc647cf8800ffee7193fba2e9 ad7be83ba3ab9b72e380faabc7b3b6d96bc4bab3 M Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.
Full output: http://webkit-queues.webkit.org/results/7877672
(In reply to Ryan Haddad from comment #53)
> stress/error-stack-trace-limit.js is failing on debug JSC bots:
>
> stress/error-stack-trace-limit.js.default: Exception: TypeError: undefined
> is not an object
> stress/error-stack-trace-limit.js.default: ERROR: Unexpected exit code: 3
> FAIL: stress/error-stack-trace-limit.js.default
>
> https://build.webkit.org/builders/
> Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/1081
That was fixed in https://trac.webkit.org/changeset/232355.
2018-05-25 14:53 PDT, Keith Miller
2018-05-25 15:18 PDT, Keith Miller
2018-05-29 10:51 PDT, Keith Miller
2018-05-29 11:55 PDT, EWS Watchlist
2018-05-29 11:57 PDT, EWS Watchlist
2018-05-29 12:24 PDT, EWS Watchlist
2018-05-29 12:38 PDT, Keith Miller
2018-05-29 13:39 PDT, EWS Watchlist
2018-05-29 14:30 PDT, EWS Watchlist
2018-05-29 14:38 PDT, EWS Watchlist
2018-05-29 15:58 PDT, EWS Watchlist
2018-05-29 18:48 PDT, Keith Miller
2018-05-29 20:04 PDT, EWS Watchlist
2018-05-29 20:38 PDT, EWS Watchlist
2018-05-29 20:42 PDT, EWS Watchlist
2018-05-30 00:01 PDT, EWS Watchlist
2018-05-30 09:43 PDT, Keith Miller
2018-05-30 10:49 PDT, EWS Watchlist
2018-05-30 11:30 PDT, EWS Watchlist
2018-05-30 11:40 PDT, EWS Watchlist
2018-05-30 13:09 PDT, EWS Watchlist
2018-05-30 13:28 PDT, Keith Miller
2018-05-30 15:01 PDT, Keith Miller
commit-queue: commit-queue-