| Summary: | Minor ApplicationCacheStorage clean up | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, beidson, commit-queue, dbates, ews-watchlist, ggaren, japhet, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2018-05-25 09:32:13 PDT
Created attachment 341294 [details]
Patch
Comment on attachment 341294 [details] Patch r = me as long as bots are happy. Some potential improvements below. View in context: https://bugs.webkit.org/attachment.cgi?id=341294&action=review > Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1474 > +HashSet<RefPtr<SecurityOrigin>> ApplicationCacheStorage::originsWithCache() Maybe HashSet<Ref<>>? > Source/WebCore/loader/appcache/ApplicationCacheStorage.h:106 > + WEBCORE_EXPORT ApplicationCacheStorage(const String& cacheDirectory, const String& flatFileSubdirectoryName); Could probably be String&& > Source/WebCore/loader/appcache/ApplicationCacheStorage.h:110 > + bool getManifestURLs(Vector<URL>& urls); Could be std::optional<Vector<>> manifestURLs() > Source/WebCore/loader/appcache/ApplicationCacheStorage.h:145 > + int64_t m_maximumSize { noQuota() }; Could it be uint64_t? > Source/WebCore/loader/appcache/ApplicationCacheStorage.h:148 > + int64_t m_defaultOriginQuota { noQuota() }; Ditto. Created attachment 341298 [details]
Patch
Comment on attachment 341298 [details] Patch Clearing flags on attachment: 341298 Committed r232192: <https://trac.webkit.org/changeset/232192> All reviewed patches have been landed. Closing bug. |