Bug 185976 – Improve the performance of determining character boundaries in ComplexTextController

• Component: Text
• Status: RESOLVED DUPLICATE

[Myles C. Maxfield]

Improve the performance of determining character boundaries in ComplexTextController

[Myles C. Maxfield]

Created attachment 341258 [details]
Patch

[Myles C. Maxfield]

Created attachment 341259 [details]
Patch

[Myles C. Maxfield]

16x faster, not 4x faster.

[EWS Watchlist]

Comment on attachment 341259 [details]
Patch

Attachment 341259 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7797104

New failing tests:
fast/text/arabic-zwj-and-zwnj.html

[EWS Watchlist]

Created attachment 341261 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 341259 [details]
Patch

Attachment 341259 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7797112

New failing tests:
fast/text/arabic-zwj-and-zwnj.html

[EWS Watchlist]

Created attachment 341263 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 341259 [details]
Patch

Attachment 341259 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7797137

New failing tests:
fast/text/arabic-zwj-and-zwnj.html

[EWS Watchlist]

Created attachment 341265 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Myles C. Maxfield]

The test is failing because createAndFillGlyphPage() maps zeroWidthNonJoiner (which GeezaPro supports) to zeroWidthSpace (which GeezaPro doesn't support)

[Myles C. Maxfield]

Created attachment 341370 [details]
WIP

[EWS Watchlist]

Attachment 341370 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 341370 [details]
WIP

Attachment 341370 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7807537

New failing tests:
fast/text/arabic-zwj-and-zwnj.html
fast/text/format-control.html

[EWS Watchlist]

Created attachment 341375 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 341370 [details]
WIP

Attachment 341370 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7807676

New failing tests:
imported/blink/fast/text/international/zerowidthjoiner-should-not-render.html

[EWS Watchlist]

Created attachment 341379 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[EWS Watchlist]

Comment on attachment 341370 [details]
WIP

Attachment 341370 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7807721

New failing tests:
fast/text/arabic-zwj-and-zwnj.html
fast/text/format-control.html

[EWS Watchlist]

Created attachment 341380 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 341370 [details]
WIP

Attachment 341370 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7809084

New failing tests:
fast/text/arabic-zwj-and-zwnj.html
fast/text/format-control.html

[EWS Watchlist]

Created attachment 341387 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Myles C. Maxfield]

Created attachment 341622 [details]
WIP

[EWS Watchlist]

Attachment 341622 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/Font.cpp:204:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/graphics/Font.cpp:205:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 341622 [details]
WIP

Attachment 341622 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7881306

New failing tests:
fast/text/arabic-zwj-and-zwnj.html
fast/text/format-control.html

[EWS Watchlist]

Created attachment 341630 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 341622 [details]
WIP

Attachment 341622 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7881004

New failing tests:
imported/blink/fast/text/international/zerowidthjoiner-should-not-render.html

[EWS Watchlist]

Created attachment 341632 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[EWS Watchlist]

Comment on attachment 341622 [details]
WIP

Attachment 341622 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7881340

New failing tests:
fast/text/arabic-zwj-and-zwnj.html
fast/text/format-control.html

[EWS Watchlist]

Created attachment 341634 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 341622 [details]
WIP

Attachment 341622 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7881757

New failing tests:
fast/text/arabic-zwj-and-zwnj.html
fast/text/format-control.html

[EWS Watchlist]

Created attachment 341635 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Myles C. Maxfield]

Created attachment 341667 [details]
WIP

[EWS Watchlist]

Attachment 341667 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 341667 [details]
WIP

Attachment 341667 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7901053

New failing tests:
fast/text/soft-hyphen-min-preferred-width.html

[EWS Watchlist]

Created attachment 341670 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 341667 [details]
WIP

Attachment 341667 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7901054

New failing tests:
fast/text/soft-hyphen-min-preferred-width.html

[EWS Watchlist]

Created attachment 341671 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 341667 [details]
WIP

Attachment 341667 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7901547

New failing tests:
fast/text/soft-hyphen-min-preferred-width.html

[EWS Watchlist]

Created attachment 341675 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Myles C. Maxfield]

Created attachment 341718 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/37912480>

Comment on attachment 341718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341718&action=review

> LayoutTests/ChangeLog:14
> +        * platform/mac/fast/text/format-control-expected.png:
> +        * platform/mac/fast/text/format-control-expected.txt: Rebaseline.

This test is regressing! For example, the presence of a zero-width non-joiner is no longer preventing the fi ligature from forming on the second line.

Comment on attachment 341718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341718&action=review

> Source/WebCore/platform/graphics/Font.cpp:-203
> -        overwriteCodePoint(leftToRightMark, zeroWidthSpace);
> -        overwriteCodePoint(rightToLeftMark, zeroWidthSpace);
> -        overwriteCodePoint(leftToRightEmbed, zeroWidthSpace);
> -        overwriteCodePoint(rightToLeftEmbed, zeroWidthSpace);
> -        overwriteCodePoint(leftToRightOverride, zeroWidthSpace);
> -        overwriteCodePoint(rightToLeftOverride, zeroWidthSpace);
> -        overwriteCodePoint(leftToRightIsolate, zeroWidthSpace);
> -        overwriteCodePoint(rightToLeftIsolate, zeroWidthSpace);

I think this may regress behavior with fonts that have glyphs for these control characters (I think Arial Unicode from Microsoft is an example of that).

[Myles C. Maxfield]

*** This bug has been marked as a duplicate of bug 175778 ***