Bug 185961

Summary: Avoid constructing the string "all" repeatedly in MediaQueryParser
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, ggaren, koivisto, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2018-05-24 14:37:52 PDT
Avoid constructing the string "all" repeatedly in MediaQueryParser.
Attachments
Patch (8.02 KB, patch)
2018-05-24 14:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-05-24 14:41:06 PDT
Created attachment 341225 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-05-24 16:42:41 PDT
Comment on attachment 341225 [details] Patch Maybe we should use AtomicStrings for media types?
WebKit Commit Bot
Comment 3 2018-05-24 17:09:47 PDT
Comment on attachment 341225 [details] Patch Clearing flags on attachment: 341225 Committed r232173: <https://trac.webkit.org/changeset/232173>
WebKit Commit Bot
Comment 4 2018-05-24 17:09:48 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-05-24 17:10:21 PDT
<rdar://problem/40540318>
Darin Adler
Comment 6 2018-05-25 21:24:31 PDT
This change is OK, but I wonder why we need std::optional<String> since String already has distinct null and empty values. Maybe use a null string instead of std::nullopt?
Note You need to log in before you can comment on or make changes to this bug.