Bug 185949

Summary: jQuery UI image assets are missing on webkit.org website.
Product: WebKit Reporter: Roy Reapor <rreapor>
Component: Tools / TestsAssignee: Roy Reapor <rreapor>
Status: RESOLVED FIXED    
Severity: Major CC: aakash_jain, ap, commit-queue, ews-watchlist, lforschler, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Roy Reapor
Reported 2018-05-24 08:31:22 PDT
jQuery UI image assets missing on webkit.org website. The theme directory should also be corrected.
Attachments
Patch (237.09 KB, patch)
2018-05-24 09:56 PDT, Roy Reapor 		no flags
DetailsFormatted DiffDiff
Patch (526.21 KB, patch)
2018-05-24 15:33 PDT, Roy Reapor 		no flags
DetailsFormatted DiffDiff
Patch (527.53 KB, patch)
2018-05-25 16:04 PDT, Roy Reapor 		no flags
DetailsFormatted DiffDiff
Patch (522.56 KB, patch)
2018-06-13 14:17 PDT, Roy Reapor 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-05-24 08:31:51 PDT
<rdar://problem/40522092>
Roy Reapor
Comment 2 2018-05-24 09:56:34 PDT
Created attachment 341200 [details] Patch
Aakash Jain
Comment 3 2018-05-24 10:30:12 PDT
Comment on attachment 341200 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341200&action=review > Tools/ChangeLog:11 > + * TestResultServer/static-dashboards/run-unittests.html: Please add a small description here in ChangeLog. > Websites/webkit.org/ChangeLog:9 > + * ajax/libs/jqueryui/jquery-ui-1.8.15.min.js: Removed. Can you please update the ChangeLog to reflect why are we removing these? > Websites/webkit.org/ChangeLog:10 > + * ajax/libs/jqueryui/1.8.15/: Added. What's added here?
Roy Reapor
Comment 4 2018-05-24 10:34:47 PDT
(In reply to Aakash Jain from comment #3) > Comment on attachment 341200 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=341200&action=review > > > Tools/ChangeLog:11 > > + * TestResultServer/static-dashboards/run-unittests.html: > > Please add a small description here in ChangeLog. Will do. > > > Websites/webkit.org/ChangeLog:9 > > + * ajax/libs/jqueryui/jquery-ui-1.8.15.min.js: Removed. > > Can you please update the ChangeLog to reflect why are we removing these? Will do. > > > Websites/webkit.org/ChangeLog:10 > > + * ajax/libs/jqueryui/1.8.15/: Added. > > What's added here? I restructured the jqueryui folder. I added minified CSS and JS files in the sub directory. Should I list every file added in the changelog?
Aakash Jain
Comment 5 2018-05-24 10:43:32 PDT
Comment on attachment 341200 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341200&action=review >>> Websites/webkit.org/ChangeLog:10 >>> + * ajax/libs/jqueryui/1.8.15/: Added. >> >> What's added here? > > I restructured the jqueryui folder. I added minified CSS and JS files in the sub directory. Should I list every file added in the changelog? Probably yes, at least the name of the files. prepare-ChangeLog tool should have done that automatically. But I don't see those added files in this patch. Are you planning to add those in a separate patch?
Roy Reapor
Comment 6 2018-05-24 15:33:37 PDT
Created attachment 341229 [details] Patch
Roy Reapor
Comment 7 2018-05-24 15:37:03 PDT
This patch is for adding the jQuery UI files and image assets to source control. I set the "allow-tabs" property for all the javascript files. I will create a new bug for changing the files that depend on jQuery UI.
Aakash Jain
Comment 8 2018-05-24 17:12:27 PDT
Comment on attachment 341229 [details] Patch Looks fine to me. I have not reviewed the content of these jQuery UI files and assets. I am assuming they are copied from a standard source.
Ryan Haddad
Comment 9 2018-05-25 14:38:17 PDT
Reopening to land patch.
WebKit Commit Bot
Comment 10 2018-05-25 14:59:56 PDT
Comment on attachment 341229 [details] Patch Rejecting attachment 341229 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 341229, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 0-ab3c-d52691b4dbfc ... Currently at 232203 = 5ccac00d9f1d78e99c47617c3ea8d707bc3b1c80 r232206 = 173e91dfe48dee6de8d4d8eb7898fd2e75c200bb r232207 = f54aca8ba9c59258bc8e9cd9646fb9c666f26d68 r232208 = cc76d1f0ec98323b9a3a862535138170589cce17 r232209 = 67cab244fee824ad67059e22c5d498c38d03e851 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/7804250
Roy Reapor
Comment 11 2018-05-25 16:04:52 PDT
Created attachment 341343 [details] Patch
Roy Reapor
Comment 12 2018-05-25 16:07:07 PDT
(In reply to Roy Reapor from comment #11) > Created attachment 341343 [details] > Patch Used "svn propset allow-tabs 1 FILENAME" instead "svn propset allow-tabs on FILENAME"
EWS Watchlist
Comment 13 2018-05-25 16:08:26 PDT
Attachment 341343 [details] did not pass style-queue: ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.mouse.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.draggable.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.draggable.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.draggable.min.js:13: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.sortable.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.sortable.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.sortable.min.js:13: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.scale.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.accordion.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.accordion.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.bounce.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.resizable.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.resizable.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.resizable.min.js:13: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.pulsate.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.datepicker.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.slide.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.shake.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.transfer.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.droppable.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.droppable.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.droppable.min.js:13: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.droppable.min.js:14: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.blind.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.slider.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.slider.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.slider.min.js:13: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.fade.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.button.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.button.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.drop.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.explode.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.highlight.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.selectable.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.selectable.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.selectable.min.js:13: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.fold.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.autocomplete.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.autocomplete.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.autocomplete.min.js:13: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.dialog.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.dialog.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.dialog.min.js:14: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.dialog.min.js:15: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.dialog.min.js:16: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.dialog.min.js:17: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.tabs.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.tabs.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.clip.min.js:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 49 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 14 2018-05-31 16:43:24 PDT
Comment on attachment 341343 [details] Patch Rejecting attachment 341343 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 341343, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: s.highlight.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.pulsate.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.scale.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.shake.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.slide.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.transfer.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.accordion.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.autocomplete.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.button.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.core.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.datepicker.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.dialog.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.draggable.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.droppable.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.mouse.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.position.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.progressbar.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.resizable.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.selectable.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.slider.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.sortable.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.tabs.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.widget.min.js M Websites/webkit.org/ChangeLog ERROR from SVN: A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: The following files contain tab characters: trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.blind.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.bounce.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.clip.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.drop.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.explode.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.fade.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.fold.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.highlight.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.pulsate.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.scale.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.shake.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.slide.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.transfer.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.accordion.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.autocomplete.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.button.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.datepicker.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.dialog.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.draggable.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.droppable.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.mouse.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.resizable.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.selectable.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.slider.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.sortable.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.tabs.min.js Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. W: 77f677568fa008086daf2c0a65dd2d59ef073b7e and refs/remotes/origin/master differ, using rebase: :040000 040000 7f51824c3a2fd1993a3de64cc588adef86ff3cd1 b9cd4a1155c1d563f7c4ef29ea0b82fc7552de80 M Websites Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/7909653
Roy Reapor
Comment 15 2018-06-13 14:17:03 PDT
Created attachment 342692 [details] Patch
EWS Watchlist
Comment 16 2018-06-13 14:20:13 PDT
Attachment 342692 [details] did not pass style-queue: ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.mouse.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.draggable.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.draggable.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.draggable.min.js:13: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.sortable.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.sortable.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.sortable.min.js:13: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.scale.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.accordion.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.accordion.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.bounce.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.resizable.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.resizable.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.resizable.min.js:13: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.pulsate.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.datepicker.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.slide.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.shake.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.transfer.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.droppable.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.droppable.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.droppable.min.js:13: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.droppable.min.js:14: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.blind.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.slider.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.slider.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.slider.min.js:13: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.fade.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.button.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.button.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.drop.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.explode.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.highlight.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.selectable.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.selectable.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.selectable.min.js:13: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.fold.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.autocomplete.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.autocomplete.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.autocomplete.min.js:13: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.dialog.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.dialog.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.dialog.min.js:14: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.dialog.min.js:15: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.dialog.min.js:16: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.dialog.min.js:17: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.tabs.min.js:11: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.tabs.min.js:12: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.clip.min.js:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 49 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.
Roy Reapor
Comment 17 2018-06-13 14:24:03 PDT
Reset allow-tabs to "ON" for offending Javascript files. $ svn propdel allow-tabs FILENAME $ svn propset allow-tabs ON FILENAME It should get through SVN commit now.
Aakash Jain
Comment 18 2018-06-13 14:28:11 PDT
(In reply to Roy Reapor from comment #17) > Reset allow-tabs to "ON" for offending Javascript files. > > $ svn propdel allow-tabs FILENAME > $ svn propset allow-tabs ON FILENAME > > It should get through SVN commit now. ok, let's try it.
WebKit Commit Bot
Comment 19 2018-06-13 15:00:14 PDT
Comment on attachment 342692 [details] Patch Rejecting attachment 342692 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 342692, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: ueryui/1.8.15/ui/jquery.ui.autocomplete.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.button.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.core.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.datepicker.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.dialog.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.draggable.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.droppable.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.mouse.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.position.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.progressbar.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.resizable.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.selectable.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.slider.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.sortable.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.tabs.min.js A Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.widget.min.js M Websites/webkit.org/ChangeLog ERROR from SVN: A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: The following files contain tab characters: trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.blind.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.bounce.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.clip.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.drop.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.explode.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.fade.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.fold.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.highlight.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.pulsate.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.scale.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.shake.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.slide.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.effects.transfer.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.accordion.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.autocomplete.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.button.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.datepicker.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.dialog.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.draggable.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.droppable.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.mouse.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.resizable.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.selectable.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.slider.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.sortable.min.js trunk/Websites/webkit.org/ajax/libs/jqueryui/1.8.15/ui/jquery.ui.tabs.min.js Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. W: 85083f3602a58d2238184b383d3f33d730e40479 and refs/remotes/origin/master differ, using rebase: :040000 040000 da8a2b3cd9d88146bdc53bff86a01c95db3cce14 a7ae0fd4cf91c68b3f6c0d12da1305d88e319070 M Websites Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 46198bd7636..478979e3837 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 232811 = 46198bd7636f0d1f85e36d830fd3108707d4c169 r232812 = 44f5a110cd0e8a4b2d7b63cf9d74818fb75a0d5b r232813 = 478979e383739224b7169f237344aa2bb20bedfd Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/8168599
Roy Reapor
Comment 20 2018-06-14 10:22:55 PDT
Blocked by https://bugs.webkit.org/show_bug.cgi?id=186624
Aakash Jain
Comment 21 2018-06-14 11:09:22 PDT
Comment on attachment 342692 [details] Patch Committed r 232845: <https://trac.webkit.org/changeset/232845/webkit>
Note You need to log in before you can comment on or make changes to this bug.