Bug 185929

Summary: [ESNext][BigInt] Implement support for "=<" and ">=" relational operation
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Caio Lima <ticaiolima>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, rmorisset, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 185379    
Bug Blocks: 179001    
Attachments:
Description Flags
WIP - Patch
none
Patch
ysuzuki: review+
Patch for landing none

Description Caio Lima 2018-05-23 17:23:11 PDT 
...
Comment 1 Caio Lima 2018-05-24 20:13:25 PDT 
Created attachment 341243 [details]
WIP - Patch

It Starts
Comment 2 Caio Lima 2018-05-30 19:12:04 PDT 
Created attachment 341638 [details]
Patch
Comment 3 Yusuke Suzuki 2018-05-31 06:50:38 PDT 
Comment on attachment 341638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341638&action=review

r=me with nit.

> Source/JavaScriptCore/runtime/Operations.h:324
> +            bool result = bigIntCompare(callFrame, p1, p2, JSBigInt::ComparisonMode::LessThanOrEqual);
> +            RETURN_IF_EXCEPTION(scope, false);
> +            return result;

Just do,

scope.release();
return bigIntCompare(callFrame, p1, p2, JSBigInt::ComparisonMode::LessThanOrEqual);
Comment 4 Caio Lima 2018-05-31 18:48:11 PDT 
Created attachment 341722 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-05-31 20:30:28 PDT 
Comment on attachment 341722 [details]
Patch for landing

Clearing flags on attachment: 341722

Committed r232386: <https://trac.webkit.org/changeset/232386>
Comment 6 WebKit Commit Bot 2018-05-31 20:30:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-05-31 20:36:45 PDT 
<rdar://problem/40709873>