Bug 185919

Summary: [Web Animations] Use DEFAULT_EXPERIMENTAL_FEATURES_ENABLED for Web Animations experimental features
Product: WebKit Reporter: Antoine Quint <graouts>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
dino: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews205 for win-future none

Description Antoine Quint 2018-05-23 13:14:11 PDT
[Web Animations] Use DEFAULT_EXPERIMENTAL_FEATURES_ENABLED for Web Animations experimental features
Comment 1 Antoine Quint 2018-05-23 13:14:40 PDT
Created attachment 341119 [details]
Patch
Comment 2 Dean Jackson 2018-05-23 13:17:26 PDT
Comment on attachment 341119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341119&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1192
> -  defaultValue: true
> +  defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
>    humanReadableName: "Web Animations"

Do you want this? It means it will be turned off in Seed builds.
Comment 3 Antoine Quint 2018-05-23 13:27:01 PDT
(In reply to Dean Jackson from comment #2)
> Comment on attachment 341119 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=341119&action=review
> 
> > Source/WebKit/Shared/WebPreferences.yaml:1192
> > -  defaultValue: true
> > +  defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
> >    humanReadableName: "Web Animations"
> 
> Do you want this? It means it will be turned off in Seed builds.

I want this on only for STP.
Comment 4 EWS Watchlist 2018-05-23 16:59:27 PDT
Comment on attachment 341119 [details]
Patch

Attachment 341119 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7782001

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html
Comment 5 EWS Watchlist 2018-05-23 16:59:38 PDT
Created attachment 341149 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 6 Antoine Quint 2018-05-25 06:47:18 PDT
Committed r232186: <https://trac.webkit.org/changeset/232186>
Comment 7 Radar WebKit Bug Importer 2018-05-25 06:49:08 PDT
<rdar://problem/40553390>