Bug 185903

Summary:

Page keeps reloading when viewing photos in google drive (due to too high canvas memory limits)

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, simon.fraser

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=185908

Attachments:

Description	Flags
patch	none
patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
patch	none
Archive of layout-test-results from ews200 for win-future	none

Antti Koivisto

Reported 2018-05-23 01:14:57 PDT

Canvas memory limits are way too high for iOS.

Attachments
patch (1.61 KB, patch) 2018-05-23 01:32 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (1.59 KB, patch) 2018-05-23 01:59 PDT, Antti Koivisto	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (15.45 MB, application/zip) 2018-05-23 03:44 PDT, EWS Watchlist	no flags	Details
patch (3.60 KB, patch) 2018-05-23 04:55 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews200 for win-future (12.80 MB, application/zip) 2018-05-23 06:37 PDT, EWS Watchlist	no flags	Details
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2018-05-23 01:15:18 PDT

<rdar://problem/38420562>

Antti Koivisto

Comment 2 2018-05-23 01:32:46 PDT

Created attachment 341075 [details] patch

Antti Koivisto

Comment 3 2018-05-23 01:59:28 PDT

Created attachment 341076 [details] patch

EWS Watchlist

Comment 4 2018-05-23 03:44:31 PDT

Comment on attachment 341076 [details] patch Attachment 341076 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7774997 New failing tests: fast/canvas/canvas-crash.html fast/canvas/canvas-skia-excessive-size.html

EWS Watchlist

Comment 5 2018-05-23 03:44:33 PDT

Created attachment 341082 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Antti Koivisto

Comment 6 2018-05-23 04:55:55 PDT

Created attachment 341086 [details] patch

Antti Koivisto

Comment 7 2018-05-23 05:00:17 PDT

Also filed bug 185908 to increase simulator fake memory size.

EWS Watchlist

Comment 8 2018-05-23 06:37:39 PDT

Comment on attachment 341086 [details] patch Attachment 341086 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7776391 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html

EWS Watchlist

Comment 9 2018-05-23 06:37:50 PDT

Created attachment 341089 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

WebKit Commit Bot

Comment 10 2018-05-23 09:10:00 PDT

Comment on attachment 341086 [details] patch Clearing flags on attachment: 341086 Committed r232113: <https://trac.webkit.org/changeset/232113>

WebKit Commit Bot

Comment 11 2018-05-23 09:10:02 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.