Bug 185900

Summary: Expose $vm if window.internals is exposed
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews116 for mac-sierra
none
Archive of layout-test-results from ews202 for win-future
none
Archive of layout-test-results from ews206 for win-future
none
Patch
none
Archive of layout-test-results from ews116 for mac-sierra
none
Patch none

Description Keith Miller 2018-05-22 20:14:17 PDT
Expose $vm if window.internals is exposed
Comment 1 Keith Miller 2018-05-22 20:16:10 PDT
Created attachment 341063 [details]
Patch
Comment 2 Mark Lam 2018-05-22 20:24:21 PDT
Comment on attachment 341063 [details]
Patch

r=me
Comment 3 EWS Watchlist 2018-05-22 21:27:15 PDT
Comment on attachment 341063 [details]
Patch

Attachment 341063 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7772709

Number of test failures exceeded the failure limit.
Comment 4 EWS Watchlist 2018-05-22 21:27:16 PDT
Created attachment 341067 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-05-22 22:22:44 PDT
Comment on attachment 341063 [details]
Patch

Attachment 341063 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7772956

New failing tests:
http/tests/security/canvas-remote-read-remote-video-localhost.html
Comment 6 EWS Watchlist 2018-05-22 22:22:55 PDT
Created attachment 341072 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 7 EWS Watchlist 2018-05-23 00:50:48 PDT
Comment on attachment 341063 [details]
Patch

Attachment 341063 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7773861

New failing tests:
http/tests/security/canvas-remote-read-remote-video-localhost.html
http/tests/security/video-poster-cross-origin-crash2.html
Comment 8 EWS Watchlist 2018-05-23 00:51:00 PDT
Created attachment 341073 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 9 Keith Miller 2018-05-23 09:28:30 PDT
Created attachment 341097 [details]
Patch
Comment 10 EWS Watchlist 2018-05-23 10:34:33 PDT
Comment on attachment 341097 [details]
Patch

Attachment 341097 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7778196

Number of test failures exceeded the failure limit.
Comment 11 EWS Watchlist 2018-05-23 10:34:34 PDT
Created attachment 341104 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 12 Keith Miller 2018-05-23 17:56:51 PDT
Created attachment 341154 [details]
Patch
Comment 13 WebKit Commit Bot 2018-05-23 20:01:49 PDT
Comment on attachment 341154 [details]
Patch

Clearing flags on attachment: 341154

Committed r232143: <https://trac.webkit.org/changeset/232143>
Comment 14 WebKit Commit Bot 2018-05-23 20:01:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2018-05-23 20:04:57 PDT
<rdar://problem/40508782>