| Summary: | [POSIX] Use access() instead of stat() in FileSystem::fileExists() | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
| Component: | Platform | Assignee: | Chris Dumez <cdumez> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, ggaren, mitz, sam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 341017 [details]
Patch
Created attachment 341020 [details]
Patch
Benchmark results on another macOS machine (Mac Pro instead of MacBook Pro): stat: 0.345526 (lower is better) access: 0.20872 (lower is better) stat: 0.34333 (lower is better) access: 0.208695 (lower is better) Comment on attachment 341020 [details]
Patch
r=me
Comment on attachment 341020 [details] Patch Clearing flags on attachment: 341020 Committed r232088: <https://trac.webkit.org/changeset/232088> All reviewed patches have been landed. Closing bug. Neat! |
Created attachment 341015 [details] Benchmark Use access() instead of stat() in FileSystem::fileExists(). stat() returns a lot of information we do not leverage. Local benchmarking on macOS shows access() being > 80% faster than stat(). Benchmark results: stat: 0.31567 (lower is better) access: 0.16074 (lower is better) stat: 0.303665 (lower is better) access: 0.165468 (lower is better)