| Summary: | Do not convert testharness paths in import-w3c-tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Nardi <cnardi> | ||||
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, cdumez, ews-watchlist, glenn, lforschler, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Chris Nardi
2018-05-22 11:24:19 PDT
Created attachment 340996 [details]
Patch
Note that some WebKittens would actually like to convert all testharness paths so that some of these tests could also be run file based. (In reply to youenn fablet from comment #2) > Note that some WebKittens would actually like to convert all testharness > paths so that some of these tests could also be run file based. Right, I forgot about all of that. Bringing us closer to upstream rather than further seems preferable, as it would make it easier to share modifications back and forth. But it's probably not you I need to convince of that. :) Comment on attachment 340996 [details]
Patch
This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.
(In reply to youenn fablet from comment #2) > Note that some WebKittens would actually like to convert all testharness > paths so that some of these tests could also be run file based. We've had all the code to do this since 2014 (bug 134763), and yet we've never turned it on for WPT (and it was explicitly disabled from day one for WPT in bug 134764). We _did_ have this turned on for the old CSS WG test suite, prior to it getting merged into WPT; this was removed six years ago in bug 170647. As such, unless people are manually invoking the importer with this (and presumably any such import would simply get trampled at the next re-import), this code has been entirely dead since 2017 and we should just get rid of it. There's a real cost to rewriting tests (especially in terms of enabling export) and it seems unlikely we're ever going revert course here and start rewriting WPT. Pull request: https://github.com/WebKit/WebKit/pull/15547 Committed 265842@main (1866a4e1cf48): <https://commits.webkit.org/265842@main> Reviewed commits have been landed. Closing PR #15547 and removing active labels. |